Bug 225586 - LayoutTests/imported/w3c/web-platform-tests/fonts/math/operators.woff is missing
Summary: LayoutTests/imported/w3c/web-platform-tests/fonts/math/operators.woff is missing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
: 226246 (view as bug list)
Depends on: 225728
Blocks:
  Show dependency tree / graph
 
Reported: 2021-05-09 22:42 PDT by Cameron McCormack (:heycam)
Modified: 2021-05-26 00:19 PDT (History)
10 users (show)

See Also:

Attachments
Patch (21.71 KB, patch)
2021-05-09 22:46 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (25.77 KB, patch)
2021-05-10 14:59 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (40.50 KB, patch)
2021-05-10 23:53 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (40.43 KB, patch)
2021-05-11 14:56 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (592.27 KB, patch)
2021-05-16 21:33 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (21.71 KB, patch)
2021-05-16 22:26 PDT, Cameron McCormack (:heycam) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (37.17 KB, patch)
2021-05-17 01:17 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (50.10 KB, patch)
2021-05-17 15:16 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (21.71 KB, patch)
2021-05-18 17:48 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (38.29 KB, patch)
2021-05-19 17:42 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (69.91 KB, patch)
2021-05-20 01:16 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (70.75 KB, patch)
2021-05-20 14:44 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (72.83 KB, patch)
2021-05-21 19:14 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (72.84 KB, patch)
2021-05-23 20:42 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Followup test expectation updates (15.66 KB, patch)
2021-05-25 21:28 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (13) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-05-09 22:42:17 PDT 
This font file is referenced by a few WPTs.
Comment 1 Cameron McCormack (:heycam) 2021-05-09 22:44:47 PDT 
<rdar://77527890>
Comment 2 Cameron McCormack (:heycam) 2021-05-09 22:46:24 PDT 
Created attachment 428155 [details]
Patch
Comment 3 EWS Watchlist 2021-05-09 22:47:13 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 4 Cameron McCormack (:heycam) 2021-05-10 14:59:19 PDT 
Created attachment 428208 [details]
Patch
Comment 5 Cameron McCormack (:heycam) 2021-05-10 23:53:27 PDT 
Created attachment 428246 [details]
Patch
Comment 6 Cameron McCormack (:heycam) 2021-05-11 14:56:48 PDT 
Created attachment 428313 [details]
Patch
Comment 7 Cameron McCormack (:heycam) 2021-05-12 00:09:57 PDT 
Fred or Said, could you review this?  Some tests now pass, and others still fail, but now with different values due to different text metrics with the operators.woff font.
Comment 8 Frédéric Wang (:fredw) 2021-05-12 00:17:03 PDT 
Comment on attachment 428313 [details]
Patch

Thanks. LGTM. cc'ing lmoura as this will likely need rebase on GTK/WPE ports too.
Comment 9 Cameron McCormack (:heycam) 2021-05-12 18:39:31 PDT 
I may revise the specific updates in this patch.

I've just realized that some of the tests are flaky in WebKit, because of the way that the tests use document.fonts.ready() to wait until operators.woff to load.  (Looks like WebKit doesn't wait for layout to be flushed, which is what would trigger the font load, before resolving the ready promise.)  So I might tweak the tests to avoid that problem (since they're not testing font loading specifically), then update the expectations here afterwards.
Comment 10 Cameron McCormack (:heycam) 2021-05-16 21:33:29 PDT 
Created attachment 428808 [details]
Patch
Comment 11 Cameron McCormack (:heycam) 2021-05-16 22:26:06 PDT 
Created attachment 428810 [details]
Patch
Comment 12 Cameron McCormack (:heycam) 2021-05-17 01:17:32 PDT 
Created attachment 428815 [details]
Patch
Comment 13 Cameron McCormack (:heycam) 2021-05-17 15:16:58 PDT 
Created attachment 428877 [details]
Patch
Comment 14 Cameron McCormack (:heycam) 2021-05-18 17:48:14 PDT 
Created attachment 429010 [details]
Patch
Comment 15 Cameron McCormack (:heycam) 2021-05-19 17:42:44 PDT 
Created attachment 429122 [details]
Patch
Comment 16 Cameron McCormack (:heycam) 2021-05-20 01:16:06 PDT 
Created attachment 429146 [details]
Patch
Comment 17 Cameron McCormack (:heycam) 2021-05-20 14:44:00 PDT 
Created attachment 429226 [details]
Patch
Comment 18 Cameron McCormack (:heycam) 2021-05-21 19:14:46 PDT 
Created attachment 429388 [details]
Patch
Comment 19 Cameron McCormack (:heycam) 2021-05-23 20:42:50 PDT 
Created attachment 429498 [details]
Patch
Comment 20 EWS 2021-05-24 15:24:39 PDT 
Committed r277970 (238092@main): <https://commits.webkit.org/238092@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429498 [details].
Comment 21 Truitt Savell 2021-05-25 15:24:34 PDT 
The changes to expectations in https://trac.webkit.org/changeset/277970/webkit

has broken 9 tests:
imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-minsize-maxsize-001.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-stretch-properties-dynamic-001.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-combining.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-001.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-stretchy-002.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-001.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-005.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/presentation-markup/operators/operator-dictionary-symmetric-006.html [ Failure ]
  imported/w3c/web-platform-tests/mathml/relations/css-styling/padding-border-margin/border-002.html [ Failure ]

Test Results:
https://build.webkit.org/results/Apple-BigSur-Release-WK1-Tests/r278042%20(3014)/results.html
Comment 22 Amir Mark Jr 2021-05-25 16:35:12 PDT 
*** Bug 226246 has been marked as a duplicate of this bug. ***
Comment 23 Cameron McCormack (:heycam) 2021-05-25 21:28:43 PDT 
Created attachment 429728 [details]
Followup test expectation updates
Comment 24 EWS 2021-05-26 00:19:33 PDT 
Committed r278079 (238158@main): <https://commits.webkit.org/238158@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 429728 [details].