Bug 225573 – Remove uses of the String::toInt family of functions from the WebCore/svg and WebCore/workers directories

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Darin Adler]

Remove uses of the String::toInt family of functions from the WebCore/svg and WebCore/workers directories

[Darin Adler]

Created attachment 428107 [details]
Patch

[Darin Adler]

Created attachment 428109 [details]
Patch

[Darin Adler]

Created attachment 428111 [details]
Patch

[Darin Adler]

Comment on attachment 428111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428111&action=review

> Source/WebCore/svg/SVGToOTFFontConversion.cpp:1456
> +            if (value && *value >= 0 && *value < 1000) {
> +                m_weight = std::max(std::min((*value + 50) / 100, static_cast<int>(std::numeric_limits<uint8_t>::max())), static_cast<int>(std::numeric_limits<uint8_t>::min()));

This std::max/min stuff is not needed. We can’t get a value outside the range 0-255 when we take a number that’s required to be in the range 0-999 and divide it by 100 (with rounding). That gives us a number in the range of 0-10, nowhere near 255, and not less than 0.

I’ll remove it.

[Darin Adler]

Accidentally commit this along at the same time as the fix for bug 225577.

Committed r277245 (237514@main): <https://commits.webkit.org/237514@main>

[Radar WebKit Bug Importer]

<rdar://problem/77717702>