Bug 225571 - Remove calls to the String::toInt family of functions from JavaScriptCore
Summary: Remove calls to the String::toInt family of functions from JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-08 18:23 PDT by Darin Adler
Modified: 2021-05-08 21:16 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.98 KB, patch)
2021-05-08 18:26 PDT, Darin Adler 		sam: review+
darin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2021-05-08 18:23:29 PDT 
Remove calls to the String::toInt family of functions from JavaScriptCore
Comment 1 Darin Adler 2021-05-08 18:26:09 PDT 
Created attachment 428105 [details]
Patch
Comment 2 Darin Adler 2021-05-08 19:06:43 PDT 
Style checker is complaining that I am using the word fuzzer in the change log. This is very silly since it’s in the file name of a file I am modifying.
Comment 3 Sam Weinig 2021-05-08 19:16:54 PDT 
Comment on attachment 428105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        (Inspector::parseLocation): Use parseIntegerAllowingTrailingJunk<uintptr_t> instead of
> +        String::toIntPtr.

Why the change from intptr_t to uintptr_t here?
Comment 4 Darin Adler 2021-05-08 20:42:17 PDT 
Comment on attachment 428105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

>> Source/JavaScriptCore/ChangeLog:10
>> +        String::toIntPtr.
> 
> Why the change from intptr_t to uintptr_t here?

Unintentional. I will change it back.
Comment 5 Darin Adler 2021-05-08 21:13:16 PDT 
Comment on attachment 428105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

>>> Source/JavaScriptCore/ChangeLog:10
>>> +        String::toIntPtr.
>> 
>> Why the change from intptr_t to uintptr_t here?
> 
> Unintentional. I will change it back.

Actually, the type is JSC::SourceID, not intptr_t and not uintptr_t either. I am changing to that.
Comment 6 Darin Adler 2021-05-08 21:15:29 PDT 
Committed r277240 (237509@main): <https://commits.webkit.org/237509@main>
Comment 7 Radar WebKit Bug Importer 2021-05-08 21:16:25 PDT 
<rdar://problem/77704068>