Bug 225571 – Remove calls to the String::toInt family of functions from JavaScriptCore

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Darin Adler]

Remove calls to the String::toInt family of functions from JavaScriptCore

[Darin Adler]

Created attachment 428105 [details]
Patch

[Darin Adler]

Style checker is complaining that I am using the word fuzzer in the change log. This is very silly since it’s in the file name of a file I am modifying.

[Sam Weinig]

Comment on attachment 428105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

> Source/JavaScriptCore/ChangeLog:10
> +        (Inspector::parseLocation): Use parseIntegerAllowingTrailingJunk<uintptr_t> instead of
> +        String::toIntPtr.

Why the change from intptr_t to uintptr_t here?

[Darin Adler]

Comment on attachment 428105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

>> Source/JavaScriptCore/ChangeLog:10
>> +        String::toIntPtr.
> 
> Why the change from intptr_t to uintptr_t here?

Unintentional. I will change it back.

[Darin Adler]

Comment on attachment 428105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428105&action=review

>>> Source/JavaScriptCore/ChangeLog:10
>>> +        String::toIntPtr.
>> 
>> Why the change from intptr_t to uintptr_t here?
> 
> Unintentional. I will change it back.

Actually, the type is JSC::SourceID, not intptr_t and not uintptr_t either. I am changing to that.

[Darin Adler]

Committed r277240 (237509@main): <https://commits.webkit.org/237509@main>

[Radar WebKit Bug Importer]

<rdar://problem/77704068>