Bug 225570 – Remove uses of the WTF::String::toInt family of functions from WebKit framework sources

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Darin Adler]

Remove uses of the WTF::String::toInt family of functions from WebKit framework sources

[Darin Adler]

Created attachment 428104 [details]
Patch

[Sam Weinig]

Comment on attachment 428104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428104&action=review

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:88
> -    clientSDKVersion = charactersToUIntStrict(reinterpret_cast<const LChar*>(string), string ? std::strlen(string) : 0, &ok);
> -    return ok;
> +    auto version = parseIntegerAllowingTrailingJunk<uint32_t>(xpc_dictionary_get_string(m_initializerMessage, "client-sdk-version"));
> +    clientSDKVersion = version.valueOr(0);
> +    return version.hasValue();

It's not immediately clear to me why the AllowingTrailingJunk version is needed here.

[Darin Adler]

Comment on attachment 428104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428104&action=review

>> Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:88
>> +    return version.hasValue();
> 
> It's not immediately clear to me why the AllowingTrailingJunk version is needed here.

Oops, a mistake. Will fix before landing.

[Darin Adler]

Committed r277239 (237508@main): <https://commits.webkit.org/237508@main>

[Radar WebKit Bug Importer]

<rdar://problem/77704010>