Bug 22557 - Better memory statistics
Summary: Better memory statistics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-29 13:26 PST by Antti Koivisto
Modified: 2008-11-30 14:26 PST (History)
1 user (show)

See Also:


Attachments
patch (7.48 KB, patch)
2008-11-29 13:30 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
JS GC heap statistics (5.06 KB, patch)
2008-11-29 22:37 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff
Report free memory in central and thread caches too. (4.51 KB, patch)
2008-11-30 13:58 PST, Antti Koivisto
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2008-11-29 13:26:47 PST
We should have way to get statistics about fast malloc heap and purgeable memory.
Comment 1 Antti Koivisto 2008-11-29 13:30:04 PST
Created attachment 25600 [details]
patch
Comment 2 Alexey Proskuryakov 2008-11-29 13:54:29 PST
Comment on attachment 25600 [details]
patch

+  size_t ReturnedBytes() const;

Is that an extra space before size_t?

Please consider putting these functions in global namespace with "using" for consistency with most of WTF.

r=me
Comment 3 Antti Koivisto 2008-11-29 14:10:52 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/JavaScriptCore.exp
Sending        JavaScriptCore/wtf/FastMalloc.cpp
Sending        JavaScriptCore/wtf/FastMalloc.h
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/Misc/WebCache.mm
Sending        WebKit/mac/Misc/WebCoreStatistics.h
Sending        WebKit/mac/Misc/WebCoreStatistics.mm
Transmitting file data ........
Committed revision 38844.
Comment 4 Antti Koivisto 2008-11-29 14:11:51 PST
I didn't move the functions to global namaspace since I didn't understand the reasoning.
Comment 5 Antti Koivisto 2008-11-29 22:20:34 PST
Reopening for another patch.
Comment 6 Antti Koivisto 2008-11-29 22:20:53 PST
Comment on attachment 25600 [details]
patch

Clearing old review flag.
Comment 7 Antti Koivisto 2008-11-29 22:37:00 PST
Created attachment 25606 [details]
JS GC heap statistics
Comment 8 Antti Koivisto 2008-11-29 23:25:41 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/JavaScriptCore.exp
Sending        JavaScriptCore/runtime/Collector.cpp
Sending        JavaScriptCore/runtime/Collector.h
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/Misc/WebCoreStatistics.mm
Transmitting file data ......
Committed revision 38849.
Comment 9 Antti Koivisto 2008-11-30 13:57:43 PST
Add free size in caches.
Comment 10 Antti Koivisto 2008-11-30 13:58:49 PST
Created attachment 25617 [details]
Report free memory in central and thread caches too.
Comment 11 Mark Rowe (bdash) 2008-11-30 14:06:40 PST
Comment on attachment 25617 [details]
Report free memory in central and thread caches too.

r=me if you fix up the non-TCMalloc code to avoid breaking the debug build.
Comment 12 Antti Koivisto 2008-11-30 14:26:24 PST
Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/wtf/FastMalloc.cpp
Sending        JavaScriptCore/wtf/FastMalloc.h
Sending        WebKit/mac/ChangeLog
Sending        WebKit/mac/Misc/WebCoreStatistics.mm
Transmitting file data .....
Committed revision 38853.