Bug 225553 - Introduce JSObject::getIfPropertyExists helper
Summary: Introduce JSObject::getIfPropertyExists helper
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
Keywords: InRadar
Depends on:
Reported: 2021-05-07 20:03 PDT by Ross Kirsling
Modified: 2021-05-08 00:33 PDT (History)
8 users (show)

See Also:

Patch (6.63 KB, patch)
2021-05-07 20:07 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (6.56 KB, patch)
2021-05-07 23:43 PDT, Ross Kirsling
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (6.57 KB, patch)
2021-05-07 23:47 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2021-05-07 20:03:42 PDT
Introduce JSObject::getIfPropertyExists helper
Comment 1 Ross Kirsling 2021-05-07 20:07:31 PDT
Created attachment 428074 [details]
Comment 2 Alexey Shvayka 2021-05-07 20:41:26 PDT
Comment on attachment 428074 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=428074&action=review

Sweet! Thank you for the follow-up. I presume there might be more usages for getIfPropertyExists() in future (like around GetBindingValue).

r=me with error handling suggestion.

> Source/JavaScriptCore/runtime/JSObjectInlines.h:205
> +

Since getIfPropertyExists() call sites should check exception either way, I think we can completely drop exception handling from this helper.
At this point (hasProperty: true), we are guaranteed to be exception-free, and can just return the ternary expression.
Comment 3 Ross Kirsling 2021-05-07 23:43:04 PDT
Created attachment 428081 [details]
Patch for landing
Comment 4 Ross Kirsling 2021-05-07 23:47:00 PDT
Created attachment 428082 [details]
Patch for landing
Comment 5 EWS 2021-05-08 00:23:00 PDT Comment hidden (obsolete)
Comment 6 EWS 2021-05-08 00:32:54 PDT
Committed r277224 (237495@main): <https://commits.webkit.org/237495@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428082 [details].
Comment 7 Radar WebKit Bug Importer 2021-05-08 00:33:14 PDT