Bug 225548 – [GPUP] A small video element enters fullscreen with strange animations

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Peng Liu]

[GPUP] A small video element enters fullscreen with strange animations

[Peng Liu]

<rdar://76770068>

[Peng Liu]

Created attachment 428061 [details]
Patch

[Peng Liu]

Created attachment 428065 [details]
Fix build failures

[Peng Liu]

Created attachment 428066 [details]
Fix build failures (again)

[Eric Carlson]

Comment on attachment 428066 [details]
Fix build failures (again)

View in context: https://bugs.webkit.org/attachment.cgi?id=428066&action=review

> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:100
> +        bool inFullscreenOrPictureInPicture = false;
> +        if (auto* mediaPlayerPrivateRemote = self.mediaPlayerPrivateRemote)
> +            inFullscreenOrPictureInPicture = mediaPlayerPrivateRemote->inVideoFullscreenOrPictureInPicture();
> +
> +        if (inFullscreenOrPictureInPicture) {

Nit: this can be simplified slightly to 

    if (auto* mediaPlayerPrivateRemote = self.mediaPlayerPrivateRemote; mediaPlayerPrivateRemote && mediaPlayerPrivateRemote->inVideoFullscreenOrPictureInPicture())

[Peng Liu]

Created attachment 428093 [details]
Patch for landing

[Peng Liu]

Comment on attachment 428066 [details]
Fix build failures (again)

View in context: https://bugs.webkit.org/attachment.cgi?id=428066&action=review

>> Source/WebKit/WebProcess/GPU/media/cocoa/VideoLayerRemoteCocoa.mm:100
>> +        if (inFullscreenOrPictureInPicture) {
> 
> Nit: this can be simplified slightly to 
> 
>     if (auto* mediaPlayerPrivateRemote = self.mediaPlayerPrivateRemote; mediaPlayerPrivateRemote && mediaPlayerPrivateRemote->inVideoFullscreenOrPictureInPicture())

Good idea! Fixed.

[EWS]

Committed r277242 (237511@main): <https://commits.webkit.org/237511@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428093 [details].