Bug 225543 - Web Inspector: Breakpoint action add/remove buttons are not vertically aligned with action dropdown
Summary: Web Inspector: Breakpoint action add/remove buttons are not vertically aligne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Patrick Angle
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-07 15:33 PDT by Patrick Angle
Modified: 2021-05-07 17:01 PDT (History)
4 users (show)

See Also:

Attachments
Screenshot of Patch v1.0 (25.09 KB, image/png)
2021-05-07 15:34 PDT, Patrick Angle 		no flags Details
Patch v1.0 (1.51 KB, patch)
2021-05-07 15:38 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Patch v1.1 (1.65 KB, patch)
2021-05-07 16:08 PDT, Patrick Angle 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Angle 2021-05-07 15:33:14 PDT 
.
Comment 1 Radar WebKit Bug Importer 2021-05-07 15:33:39 PDT 
<rdar://problem/77675982>
Comment 2 Patrick Angle 2021-05-07 15:34:22 PDT 
Created attachment 428045 [details]
Screenshot of Patch v1.0
Comment 3 Patrick Angle 2021-05-07 15:38:04 PDT 
Created attachment 428048 [details]
Patch v1.0
Comment 4 Devin Rousso 2021-05-07 15:46:24 PDT 
Comment on attachment 428048 [details]
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=428048&action=review

r=me with one adjustment

> Source/WebInspectorUI/UserInterface/Views/BreakpointActionView.css:32
> +.breakpoint-action-button-container {
> +    padding-block-start: 3px;
> +}

I think we should either make this `5px` and remove the `margin-top: 2px` from `:matches(.breakpoint-action-append-button, .breakpoint-action-remove-button)` or do the opposite.
Comment 5 Patrick Angle 2021-05-07 16:08:10 PDT 
Created attachment 428053 [details]
Patch v1.1
Comment 6 EWS 2021-05-07 17:01:39 PDT 
Committed r277213 (237484@main): <https://commits.webkit.org/237484@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428053 [details].