Bug 225541 – [iPadOS] Do not present custom input peripherals when switching back to a tab with a focused element

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Aditya Keerthi]

...

[Aditya Keerthi]

<rdar://problem/77537795>

[Aditya Keerthi]

Created attachment 428038 [details]
Patch

[Wenson Hsieh]

Comment on attachment 428038 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428038&action=review

> LayoutTests/fast/forms/ios/focus-select-and-switch-tabs.html:35
> +    await UIHelper.delayFor(2000);

Nit - though an arbitrary time for a test like this is fine, 2 seconds seems a tad excessive…

Does it still reliably fail (without the fix) if we bring it down to say, 500 ms?

[Wenson Hsieh]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 428038 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428038&action=review
> 
> > LayoutTests/fast/forms/ios/focus-select-and-switch-tabs.html:35
> > +    await UIHelper.delayFor(2000);
> 
> Nit - though an arbitrary time for a test like this is fine, 2 seconds seems
> a tad excessive…
> 
> Does it still reliably fail (without the fix) if we bring it down to say,
> 500 ms?

Alternately, a faster (and potentially more reliable way to test) might be to add a script controller hook to query whether or not there's an active input peripheral, and then just wait for a presentation update (to ensure that the UI process receives the `_elementDidFocus:`, and then just check that the hook returns `NO`).

[Aditya Keerthi]

Created attachment 428064 [details]
Patch for landing

[Aditya Keerthi]

(In reply to Wenson Hsieh from comment #3)
> Comment on attachment 428038 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428038&action=review
> 
> > LayoutTests/fast/forms/ios/focus-select-and-switch-tabs.html:35
> > +    await UIHelper.delayFor(2000);
> 
> Nit - though an arbitrary time for a test like this is fine, 2 seconds seems
> a tad excessive…
> 
> Does it still reliably fail (without the fix) if we bring it down to say,
> 500 ms?

Removed the arbitrary time by waiting for a presentation update and attempting to use the menu to change the selected option.

[EWS]

Committed r277265 (237532@main): <https://commits.webkit.org/237532@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428064 [details].