Bug 225535 – [JSC] Error#cause must recognize explicit undefined

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Ross Kirsling]

See https://github.com/tc39/proposal-error-cause/issues/2#issuecomment-789375512.

[Ross Kirsling]

Created attachment 428057 [details]
Patch

[Alexey Shvayka]

Comment on attachment 428057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428057&action=review

Nice clean-up! r=me with a thought on (micro) optimization.

> Source/JavaScriptCore/runtime/ErrorInstance.cpp:145
> +            JSValue cause = object->get(globalObject, vm.propertyNames->cause);

We could use slot.isTaintedByOpaqueObject() to avoid this get() if it's non-observable, like we do in objectConstructorValues() and friends.

[Ross Kirsling]

(In reply to Alexey Shvayka from comment #2)
> Comment on attachment 428057 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428057&action=review
> 
> Nice clean-up! r=me with a thought on (micro) optimization.
> 
> > Source/JavaScriptCore/runtime/ErrorInstance.cpp:145
> > +            JSValue cause = object->get(globalObject, vm.propertyNames->cause);
> 
> We could use slot.isTaintedByOpaqueObject() to avoid this get() if it's
> non-observable, like we do in objectConstructorValues() and friends.

Thanks, will do!

[Ross Kirsling]

Created attachment 428063 [details]
Patch for landing

[EWS]

Committed r277221 (237492@main): <https://commits.webkit.org/237492@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428063 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77682622>

[Truitt Savell]

It looks like the changes in https://trac.webkit.org/changeset/277221/webkit

broke two tests on test262 queue
https://build.webkit.org/#/builders/19/builds/2485