Bug 22552 – Provide some abstraction of JIT code generation, to increase portability.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Introduce a MacroAssembler layer, abstracting the architecture specific assembler.  Initially, port WREC to the new abstraction.

[Gavin Barraclough]

Created attachment 25592 [details]
The patch

[Gavin Barraclough]

Created attachment 25593 [details]
The patch, having hit 'save' on the Changelog

[Cameron Zwarich (cpst)]

Comment on attachment 25593 [details]
The patch, having hit 'save' on the Changelog

This patch makes the WREC code so much cleaner. It will be a good day when we can also apply this to the JS JIT.

Most of my comments are about order of declarations. In structs, we generally put constructors first and members afterwards. In classes, we generally put public: before private: and do not rely upon the implicit private: of a class definition.

If you fix up the order of declarations, r=me.

[Gavin Barraclough]

Sending        JavaScriptCore/ChangeLog
Sending        JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
Adding         JavaScriptCore/assembler/MacroAssembler.h
Sending        JavaScriptCore/assembler/X86Assembler.h
Sending        JavaScriptCore/interpreter/Interpreter.cpp
Sending        JavaScriptCore/interpreter/Interpreter.h
Sending        JavaScriptCore/runtime/RegExp.cpp
Sending        JavaScriptCore/wrec/WREC.cpp
Sending        JavaScriptCore/wrec/WREC.h
Sending        JavaScriptCore/wrec/WRECFunctors.cpp
Sending        JavaScriptCore/wrec/WRECFunctors.h
Sending        JavaScriptCore/wrec/WRECGenerator.cpp
Sending        JavaScriptCore/wrec/WRECGenerator.h
Sending        JavaScriptCore/wrec/WRECParser.cpp
Sending        JavaScriptCore/wrec/WRECParser.h
Sending        JavaScriptCore/wtf/Platform.h
Transmitting file data ................
Committed revision 38839.