Bug 225510 - [SOUP] Use the new libsoup network metrics API
Summary: [SOUP] Use the new libsoup network metrics API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: libsoup3
  Show dependency tree / graph
 
Reported: 2021-05-07 05:25 PDT by Carlos Garcia Campos
Modified: 2021-05-08 03:43 PDT (History)
2 users (show)

See Also:

Attachments
Patch (15.31 KB, patch)
2021-05-07 05:28 PDT, Carlos Garcia Campos 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2021-05-07 05:25:31 PDT 
.
Comment 1 Carlos Garcia Campos 2021-05-07 05:28:35 PDT 
Created attachment 427994 [details]
Patch
Comment 2 Michael Catanzaro 2021-05-07 08:18:29 PDT 
Comment on attachment 427994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review

> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286
> +            if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) {

The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK.
Comment 3 Carlos Garcia Campos 2021-05-08 03:30:34 PDT 
Comment on attachment 427994 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427994&action=review

>> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:286
>> +            if (!g_cancellable_is_cancelled(protectCancellable.get()) && !m_networkLoadMetrics.fetchStart) {
> 
> The fact that the operation can be cancelled before returning to the main loop is strange and confusing, but you do at least have a warning comment up above, so... I guess that's OK.

I agree. It only happens when hsts cancels the load to start a https one.
Comment 4 Carlos Garcia Campos 2021-05-08 03:43:16 PDT 
Committed r277225 (237496@main): <https://commits.webkit.org/237496@main>