Bug 225501 – [WinCairo] Remove linker warning on ANGLE

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Basuke Suzuki]

There're two warnings displayed when creating library lib64\libGLESv2.lib and object lib64\libGLESv2.exp:

LINK : warning LNK4217: symbol 'ANGLEGetDisplayPlatform' defined in 'ANGLE.lib(Platform.obj)' is imported by 'proc_table_egl_autogen.obj' in function '"void __cdecl egl::`dynamic initializer for 'g_procTable''(void)" (??__Eg_procTable@egl@@YAXXZ)' [W:\WebKit\WebKitBuild\Release\Source\ThirdParty\ANGLE\GLESv2.vcxproj]
LINK : warning LNK4217: symbol 'ANGLEResetDisplayPlatform' defined in 'ANGLE.lib(Platform.obj)' is imported by 'proc_table_egl_autogen.obj' in function '"void __cdecl egl::`dynamic initializer for 'g_procTable''(void)" (??__Eg_procTable@egl@@YAXXZ)' [W:\WebKit\WebKitBuild\Release\Source\ThirdParty\ANGLE\GLESv2.vcxproj]

[Basuke Suzuki]

I'm still beginner of Windows build env, but my understanding of this warning is:
- ANGLE is compiled as static library
- That is linked to libGLESv2.dll
- __declspec(dllimport) is not required in this case

Is my understanding correct?

[Basuke Suzuki]

Created attachment 428039 [details]
PATCH

[EWS Watchlist]

Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE

[Darin Adler]

Comment on attachment 428039 [details]
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=428039&action=review

> Source/ThirdParty/ANGLE/ChangeLog:8
> +        libANGLE is statically linked to libGLESv2.dll so that __declspec(dllimport) is not required here.

is *now* statically linked; we changed that recently

[EWS]

Committed r277241 (237510@main): <https://commits.webkit.org/237510@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428039 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77704188>

[Basuke Suzuki]

> is *now* statically linked; we changed that recently


Make sense. Thanks!