Bug 225497 - Make CanvasRenderingContext always non-null in CanvasBase
Summary: Make CanvasRenderingContext always non-null in CanvasBase
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 17:17 PDT by Sam Weinig
Modified: 2021-05-13 17:18 PDT (History)
28 users (show)

See Also:


Attachments
Patch (106.64 KB, patch)
2021-05-06 17:23 PDT, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (107.64 KB, patch)
2021-05-06 17:34 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (107.65 KB, patch)
2021-05-07 08:33 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (111.75 KB, patch)
2021-05-07 09:05 PDT, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (115.79 KB, patch)
2021-05-07 11:10 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (116.05 KB, patch)
2021-05-07 13:34 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (114.10 KB, patch)
2021-05-07 14:04 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (114.99 KB, patch)
2021-05-07 16:39 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (115.10 KB, patch)
2021-05-07 17:46 PDT, Sam Weinig
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-06 17:17:07 PDT
Make CanvasRenderingContext always non-null in CanvasBase
Comment 1 Sam Weinig 2021-05-06 17:23:53 PDT Comment hidden (obsolete)
Comment 2 Sam Weinig 2021-05-06 17:34:38 PDT Comment hidden (obsolete)
Comment 3 Sam Weinig 2021-05-07 08:33:46 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2021-05-07 09:05:56 PDT Comment hidden (obsolete)
Comment 5 Sam Weinig 2021-05-07 11:10:47 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2021-05-07 13:34:21 PDT Comment hidden (obsolete)
Comment 7 Sam Weinig 2021-05-07 14:04:49 PDT Comment hidden (obsolete)
Comment 8 Sam Weinig 2021-05-07 16:39:28 PDT
Created attachment 428060 [details]
Patch
Comment 9 Dean Jackson 2021-05-07 17:06:20 PDT
Comment on attachment 428060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review

> Source/WTF/ChangeLog:10
> +        Add new helper to allow making UniqueRefs in a slight easier manner than always friending.

typo: slightly
Comment 10 Darin Adler 2021-05-07 17:11:03 PDT
Comment on attachment 428060 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428060&action=review

> Source/WTF/wtf/UniqueRef.h:88
> +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);

This needs "adopt" in its name.
Comment 11 Sam Weinig 2021-05-07 17:35:15 PDT
(In reply to Darin Adler from comment #10)
> Comment on attachment 428060 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428060&action=review
> 
> > Source/WTF/wtf/UniqueRef.h:88
> > +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);
> 
> This needs "adopt" in its name.

WTF::makeUniqueRefAdoptingReference()?
Comment 12 Sam Weinig 2021-05-07 17:43:16 PDT
(In reply to Sam Weinig from comment #11)
> (In reply to Darin Adler from comment #10)
> > Comment on attachment 428060 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=428060&action=review
> > 
> > > Source/WTF/wtf/UniqueRef.h:88
> > > +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);
> > 
> > This needs "adopt" in its name.
> 
> WTF::makeUniqueRefAdoptingReference()?

WTF::adoptReferenceMakingUniqueRef()?
Comment 13 Sam Weinig 2021-05-07 17:43:36 PDT
(In reply to Sam Weinig from comment #12)
> (In reply to Sam Weinig from comment #11)
> > (In reply to Darin Adler from comment #10)
> > > Comment on attachment 428060 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=428060&action=review
> > > 
> > > > Source/WTF/wtf/UniqueRef.h:88
> > > > +    template<class U> friend UniqueRef<U> makeUniqueRefFromReference(U&);
> > > 
> > > This needs "adopt" in its name.
> > 
> > WTF::makeUniqueRefAdoptingReference()?
> 
> WTF::adoptReferenceMakingUniqueRef()?

Going to go with the latter.
Comment 14 Sam Weinig 2021-05-07 17:46:02 PDT
Created attachment 428067 [details]
Patch
Comment 15 Radar WebKit Bug Importer 2021-05-13 17:18:21 PDT
<rdar://problem/77995159>