Bug 225493 - css-display-none actions from WKContentRuleList should apply to pages loaded with loadData and loadHTMLString
Summary: css-display-none actions from WKContentRuleList should apply to pages loaded ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 16:30 PDT by Alex Christensen
Modified: 2021-05-10 09:56 PDT (History)
5 users (show)

See Also:


Attachments
Patch (6.47 KB, patch)
2021-05-06 16:32 PDT, Alex Christensen
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-05-06 16:30:14 PDT
css-display-none actions from WKContentRuleList should apply to pages loaded with loadData and loadHTMLString
Comment 1 Alex Christensen 2021-05-06 16:32:05 PDT
Created attachment 427952 [details]
Patch
Comment 2 Alex Christensen 2021-05-06 16:32:08 PDT
<rdar://problem/77331789>
Comment 3 Darin Adler 2021-05-08 22:00:58 PDT
Comment on attachment 427952 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427952&action=review

> Source/WebCore/loader/DocumentLoader.cpp:528
> +        // We want the CSS but not the blocking or upgrading for substitute data.

Based on your change log comment I would write something more like: "We want the CSS to be loaded for us, but we ignore any attempt to block or upgrade the connection since there is no connection."

Not sure my sentence was accurate, but I think it’s easier to understand than "[don’t want] the blocking or upgrading" and instead of saying "for substitute data" which is already said by the name of the function we are in, we can point out *why* we ignore attempts to block or upgrade.
Comment 4 Alex Christensen 2021-05-10 09:56:28 PDT
That's a great comment suggestion.  Taken.
r277268