Bug 225480 - Sampled Page Top Color: move logic out of `Document`
Summary: Sampled Page Top Color: move logic out of `Document`
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 13:41 PDT by Devin Rousso
Modified: 2021-05-14 17:29 PDT (History)
15 users (show)

See Also:

Attachments
Patch (25.72 KB, patch)
2021-05-06 13:42 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (26.43 KB, patch)
2021-05-06 15:33 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (37.85 KB, patch)
2021-05-13 18:25 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (37.83 KB, patch)
2021-05-14 16:40 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-05-06 13:41:33 PDT 
.
Comment 1 Devin Rousso 2021-05-06 13:42:46 PDT 
Created attachment 427931 [details]
Patch
Comment 2 Devin Rousso 2021-05-06 15:33:14 PDT 
Created attachment 427944 [details]
Patch
Comment 3 Sam Weinig 2021-05-07 09:17:37 PDT 
Comment on attachment 427944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427944&action=review

> Source/WebCore/ChangeLog:4
> +        Sampled Page Top Color: move logic out of `Document`
> +        https://bugs.webkit.org/show_bug.cgi?id=225480

If you are moving it out of Document, might I suggest moving it to its own struct/class? It seems like an object Page could own.
Comment 4 Darin Adler 2021-05-08 22:01:54 PDT 
Comment on attachment 427944 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427944&action=review

>> Source/WebCore/ChangeLog:4
>> +        https://bugs.webkit.org/show_bug.cgi?id=225480
> 
> If you are moving it out of Document, might I suggest moving it to its own struct/class? It seems like an object Page could own.

I agree that this is a good suggestion.
Comment 5 Radar WebKit Bug Importer 2021-05-13 13:42:15 PDT 
<rdar://problem/77984539>
Comment 6 Devin Rousso 2021-05-13 18:25:02 PDT 
Created attachment 428591 [details]
Patch
Comment 7 EWS 2021-05-14 15:30:55 PDT 
Tools/Scripts/svn-apply failed to apply attachment 428591 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 8 Devin Rousso 2021-05-14 16:40:48 PDT 
Created attachment 428683 [details]
Patch
Comment 9 EWS 2021-05-14 17:29:27 PDT 
Committed r277523 (237751@main): <https://commits.webkit.org/237751@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428683 [details].