Bug 225477 - Add ObjC API similar to WKBundlePageCopyGroupIdentifier
Summary: Add ObjC API similar to WKBundlePageCopyGroupIdentifier
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 12:53 PDT by Alex Christensen
Modified: 2021-05-10 12:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (10.23 KB, patch)
2021-05-06 12:55 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.14 KB, patch)
2021-05-06 13:26 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (10.45 KB, patch)
2021-05-06 13:58 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2021-05-06 12:53:21 PDT 
Add ObjC API similar to WKBundlePageCopyGroupIdentifier
Comment 1 Alex Christensen 2021-05-06 12:55:13 PDT 
Created attachment 427924 [details]
Patch
Comment 2 Alex Christensen 2021-05-06 13:26:52 PDT 
Created attachment 427928 [details]
Patch
Comment 3 Alex Christensen 2021-05-06 13:58:55 PDT 
Created attachment 427934 [details]
Patch
Comment 4 Darin Adler 2021-05-08 22:03:12 PDT 
Comment on attachment 427934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427934&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:50
> +@property (nonatomic, readonly) NSString *_groupIdentifier WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));

Bug title says API, but this has an underscore and is private. Should this be API?
Comment 5 Alex Christensen 2021-05-10 09:04:55 PDT 
All of our injected bundle API is private.  This should be private.
Comment 6 Alex Christensen 2021-05-10 10:11:31 PDT 
Comment on attachment 427934 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427934&action=review

> Source/WebKit/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInPageGroup.h:30
> +WK_CLASS_DEPRECATED_WITH_REPLACEMENT("WKWebProcessPlugInBrowserContextController._groupIdentifier", macos(10.10, WK_MAC_TBA), ios(8.0, WK_IOS_TBA))

Internal commit 94dff8a788b4d924ccfabf211f3daf39dbd63d12 to ignore this deprecation for staging.
Comment 7 Alex Christensen 2021-05-10 11:59:10 PDT 
http://trac.webkit.org/r277280
Comment 8 Radar WebKit Bug Importer 2021-05-10 12:00:22 PDT 
<rdar://problem/77773734>