Bug 225473 - Make it easy to pass __XPC variables to run-benchmark
Summary: Make it easy to pass __XPC variables to run-benchmark
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 11:40 PDT by Filip Pizlo
Modified: 2021-05-06 11:59 PDT (History)
6 users (show)

See Also:

Attachments
the patch (2.31 KB, patch)
2021-05-06 11:41 PDT, Filip Pizlo 		slewis: review+
fpizlo: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2021-05-06 11:40:22 PDT 
...
Comment 1 Filip Pizlo 2021-05-06 11:41:11 PDT 
Created attachment 427914 [details]
the patch
Comment 2 Simon Fraser (smfr) 2021-05-06 11:52:12 PDT 
Comment on attachment 427914 [details]
the patch

Could you fix the help to show how to do this too please?
Comment 3 Filip Pizlo 2021-05-06 11:53:07 PDT 
(In reply to Simon Fraser (smfr) from comment #2)
> Comment on attachment 427914 [details]
> the patch
> 
> Could you fix the help to show how to do this too please?

Sure!
Comment 4 Filip Pizlo 2021-05-06 11:53:53 PDT 
Comment on attachment 427914 [details]
the patch

Going to land a different patch, that includes changes to the help text.
Comment 5 Filip Pizlo 2021-05-06 11:58:56 PDT 
Landed in https://trac.webkit.org/changeset/277105/webkit
Comment 6 Radar WebKit Bug Importer 2021-05-06 11:59:18 PDT 
<rdar://problem/77618796>