navigator.languages now says "en-us" instead of "en-US". The case does not match the specification not other browsers.
Created attachment 427902 [details] Patch
Created attachment 427910 [details] Patch
Comment on attachment 427910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427910&action=review > Source/WTF/wtf/cf/LanguageCF.cpp:-88 > - CFStringLowercase(mutableLanguageCode.get(), nullptr); So this is a CoreFoundation-only regression, not affecting non-CoreFoundation-using WebKit ports? > LayoutTests/ChangeLog:11 > + * fast/text/international/system-language/navigator-language/navigator-language-en-GB-expected.txt: > + * fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: How can a CoreFoundation-only fix affect non-platform-specific expected.txt files? > LayoutTests/ChangeLog:45 > + * js/dom/navigator-language-expected.txt: > + * js/dom/navigator-language.html: I don’t see changes to these two files in the patch.
Comment on attachment 427910 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427910&action=review >> LayoutTests/ChangeLog:11 >> + * fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: > > How can a CoreFoundation-only fix affect non-platform-specific expected.txt files? I will check what's the story for other ports. >> LayoutTests/ChangeLog:45 >> + * js/dom/navigator-language.html: > > I don’t see changes to these two files in the patch. Oh, my latest iteration only modifies the latter one. > LayoutTests/js/dom/navigator-language.html:18 > +if (language == "en" || language == "en-US") The change is here.
(In reply to Chris Dumez from comment #4) > Comment on attachment 427910 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427910&action=review > > >> LayoutTests/ChangeLog:11 > >> + * fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: > > > > How can a CoreFoundation-only fix affect non-platform-specific expected.txt files? > > I will check what's the story for other ports. Where it seems they are skipped and masked as failing: LayoutTests/platform/win/TestExpectations:fast/text/international/system-language [ Skip ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-en-GB.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-en.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-en-US.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es-419.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es-ES.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-es-MX.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-fr-CA.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-fr.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-hi.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-ja.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-pt-BR.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-pt-PT.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-Hans.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-Hant-HK.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-Hant.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-HK.html [ Failure ] LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 fast/text/international/system-language/navigator-language/navigator-language-zh-TW.html [ Failure ] LayoutTests/platform/gtk/TestExpectations:webkit.org/b/158472 fast/text/international/system-language/han-quotes.html [ ImageOnlyFailure Pass ]
(In reply to Chris Dumez from comment #5) > (In reply to Chris Dumez from comment #4) > > Comment on attachment 427910 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=427910&action=review > > > > >> LayoutTests/ChangeLog:11 > > >> + * fast/text/international/system-language/navigator-language/navigator-language-en-GB.html: > > > > > > How can a CoreFoundation-only fix affect non-platform-specific expected.txt files? > > > > I will check what's the story for other ports. > > Where it seems they are skipped and masked as failing: > LayoutTests/platform/win/TestExpectations:fast/text/international/system- > language [ Skip ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-en-GB.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-en.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-en-US.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-es-419.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-es-ES.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-es.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-es-MX.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-fr-CA.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-fr.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-hi.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-ja.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-pt-BR.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-pt-PT.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-ru.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-zh-Hans.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-zh-Hant-HK.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-zh-Hant.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-zh-HK.html [ Failure ] > LayoutTests/platform/glib/TestExpectations:webkit.org/b/152618 > fast/text/international/system-language/navigator-language/navigator- > language-zh-TW.html [ Failure ] > LayoutTests/platform/gtk/TestExpectations:webkit.org/b/158472 > fast/text/international/system-language/han-quotes.html [ ImageOnlyFailure > Pass ] Looks like the other ports are missing test infrastructure to change the system language. For this reason, the tests are skipped or marked as failing.
Created attachment 427933 [details] Patch
Committed r277135 (237424@main): <https://commits.webkit.org/237424@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427933 [details].
<rdar://problem/77629484>
Thanks for fixing this!