RESOLVED FIXED Bug 225452
Use IPC::Semaphore instead of sending an IPC message for every captured audio sample 
https://bugs.webkit.org/show_bug.cgi?id=225452
Summary Use IPC::Semaphore instead of sending an IPC message for every captured audio...
youenn fablet
Reported 2021-05-06 05:04:11 PDT
Use IPC::Semaphore instead of sending an IPC message for every captured audio sample
Attachments
Patch (14.71 KB, patch)
2021-05-06 05:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.84 KB, patch)
2021-05-06 06:27 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (16.74 KB, patch)
2021-05-06 06:28 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (15.15 KB, patch)
2021-05-06 08:21 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.71 KB, patch)
2021-05-07 08:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Patch (17.69 KB, patch)
2021-05-07 09:45 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2021-05-06 05:07:38 PDT
Created attachment 427873 [details] Patch
youenn fablet
Comment 2 2021-05-06 05:47:58 PDT
I reused the web audio model but this might not be an optimal approach given we use chunks of 128 samples, while the AudioUnit may use larger chunks. Another approach would be to keep using fixed sample size, say 5 or 10 ms, something like std::max(128, sampleRate / 100). Thoughts?
youenn fablet
Comment 3 2021-05-06 06:27:41 PDT
Created attachment 427879 [details] Patch
youenn fablet
Comment 4 2021-05-06 06:28:46 PDT
Created attachment 427880 [details] Patch
youenn fablet
Comment 5 2021-05-06 08:21:34 PDT
Created attachment 427887 [details] Patch
youenn fablet
Comment 6 2021-05-07 08:45:07 PDT
Created attachment 428000 [details] Patch
youenn fablet
Comment 7 2021-05-07 09:45:32 PDT
Created attachment 428004 [details] Patch
EWS
Comment 8 2021-05-10 00:10:38 PDT
Committed r277256 (237525@main): <https://commits.webkit.org/237525@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428004 [details].
Radar WebKit Bug Importer
Comment 9 2021-05-10 00:11:16 PDT
<rdar://problem/77731343>
Note You need to log in before you can comment on or make changes to this bug.