Bug 225446 – Don't allow :visited link style in subtrees that use mix-blend-mode

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Antti Koivisto]

They don't mix

[Antti Koivisto]

rdar://65686091

[Antti Koivisto]

Created attachment 427868 [details]
patch

[Antti Koivisto]

Created attachment 427877 [details]
patch

[Antti Koivisto]

Created attachment 427886 [details]
patch

[Darin Adler]

Comment on attachment 427886 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427886&action=review

> Source/WebCore/rendering/style/RenderStyle.h:827
> +    void setBlendMode(BlendMode mode)
> +    {
> +        SET_VAR(m_rareNonInheritedData, effectiveBlendMode, static_cast<unsigned>(mode));
> +        SET_VAR(m_rareInheritedData, isInSubtreeWithBlendMode, mode != BlendMode::Normal);
> +    }

I find these multi-line function bodies inside class definitions make it hard for me to get an overview of what’s in the class. Would you consider moving the inline function body below the class definition?

[Antti Koivisto]

Created attachment 428263 [details]
patch

[EWS]

Committed r277320 (237579@main): <https://commits.webkit.org/237579@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428263 [details].

[Antti Koivisto]

Created attachment 428272 [details]
windows build fix

[Antti Koivisto]

build fix

[EWS]

Committed r277329 (237588@main): <https://commits.webkit.org/237588@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428272 [details].

[WebKit Commit Bot]

Re-opened since this is blocked by bug 225698

[Antti Koivisto]

Created attachment 428617 [details]
patch

reland with test disabled on windows

[Antti Koivisto]

Created attachment 428716 [details]
patch

[EWS]

Committed r277538 (237766@main): <https://commits.webkit.org/237766@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428716 [details].