Bug 225443 - will-change: position should not create a containing block for position: fixed elements
Summary: will-change: position should not create a containing block for position: fixe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Nguyen (:ntim)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 02:30 PDT by Tim Nguyen (:ntim)
Modified: 2021-05-17 03:09 PDT (History)
11 users (show)

See Also:

Attachments
Patch (5.25 KB, patch)
2021-05-16 02:01 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (6.03 KB, patch)
2021-05-16 09:31 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (6.34 KB, patch)
2021-05-16 09:35 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Patch (6.26 KB, patch)
2021-05-16 09:37 PDT, Tim Nguyen (:ntim) 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Nguyen (:ntim) 2021-05-06 02:30:34 PDT 
Not sure why tbh, but Chrome & Edge also fail here. Only Firefox passes.
Comment 2 Radar WebKit Bug Importer 2021-05-13 02:31:17 PDT 
<rdar://problem/77958400>
Comment 3 Tim Nguyen (:ntim) 2021-05-16 01:49:01 PDT 
I got some clarification from Emilio:

No value of `position` triggers a containing block for a position: fixed; child element, so `will-change: position` also shouldn't trigger a containing block.
Comment 4 Tim Nguyen (:ntim) 2021-05-16 02:01:02 PDT 
Created attachment 428779 [details]
Patch
Comment 5 Simon Fraser (smfr) 2021-05-16 08:26:59 PDT 
Comment on attachment 428779 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=428779&action=review

> Source/WebCore/ChangeLog:8
> +        Marked relevant WPT as pass.

Please write more words here about how you are undoing a previous change. Reference that other commit, and reference the test that is exercising the change.
Comment 6 Tim Nguyen (:ntim) 2021-05-16 09:31:21 PDT 
Created attachment 428791 [details]
Patch
Comment 7 Tim Nguyen (:ntim) 2021-05-16 09:35:59 PDT 
Created attachment 428792 [details]
Patch
Comment 8 Tim Nguyen (:ntim) 2021-05-16 09:37:54 PDT 
Created attachment 428793 [details]
Patch
Comment 9 EWS 2021-05-17 03:09:11 PDT 
Committed r277579 (237806@main): <https://commits.webkit.org/237806@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428793 [details].