Bug 225433 – Web Inspector: Layout panel "Grid Overlays" main checkbox has dead space (no interaction) between checkbox and label text

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Patrick Angle]

Created attachment 427848 [details]
Screenshot illustrating issue

The attached screenshot shows a small area where clicking on the "Grid Overlays" checkbox/label does not toggle the item. This is different from the below item for a single overlay, where that same gap space does toggle the item. System checkboxes treat that space as interactive, so our header's behavior is incorrect here.

[Radar WebKit Bug Importer]

<rdar://problem/77590883>

[Patrick Angle]

Comment on attachment 427848 [details]
Screenshot illustrating issue

This diagram is technically wrong, because the "Grid Overlays" hit box doesn't extend this far to the right, but the area of issue is still accurate.

[Nikita Vasilyev]

Created attachment 427941 [details]
Patch

[Nikita Vasilyev]

Created attachment 427942 [details]
[Video] With patch applied

[Devin Rousso]

Comment on attachment 427941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427941&action=review

r=me with some minor adjustments

> Source/WebInspectorUI/UserInterface/Views/CSSGridSection.css:69
> +.css-grid-section input[type="checkbox"] {

Can we be more specific about this selector?
```
    .css-grid-section :is(.setting-editor, .node-overlay-list-item-container) input[type="checkbox"]
```

> Source/WebInspectorUI/UserInterface/Views/CSSGridSection.js:90
> +        labelInner.append(WI.UIString("Grid Overlays", "Page Overlays @ Layout Sidebar Section Header", "Heading for list of grid nodes"));

`.textContent = `

> Source/WebInspectorUI/UserInterface/Views/SettingEditor.css:31
> +    padding-inline-start: 5px;

This used to also have `5px` of padding on the right too inside `WI.CSSGridSection`.  Do we not want that anymore?

Also, this is super NIT, but I personally think `4px` looks visually better 😅

> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css:108
> +.content-view.tab.settings > .settings-view > .container > .editor-group > .setting-editor input {
>      font-size: inherit;

I feel like we should move more of the generic styles like this to `Source/WebInspectorUI/UserInterface/Views/SettingEditor.css`.  The only stuff that should be in this file are the styles that are necessary to make the Settings Tab look good.

[Nikita Vasilyev]

Comment on attachment 427941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427941&action=review

>> Source/WebInspectorUI/UserInterface/Views/SettingEditor.css:31
>> +    padding-inline-start: 5px;
> 
> This used to also have `5px` of padding on the right too inside `WI.CSSGridSection`.  Do we not want that anymore?

I don't think we do. I just checked macOS - it doesn't arbitrary increase the clickable area to the right of the label text.

I added 5px padding initially to separate label text and the color picker swatch, and it somehow creeped in to checkbox labels that don't have color picker swatches.

[Nikita Vasilyev]

Created attachment 428184 [details]
Patch

[EWS]

Committed r277284 (237548@main): <https://commits.webkit.org/237548@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428184 [details].