WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
225426
Add SPI to restrict networking to a set of hosts
https://bugs.webkit.org/show_bug.cgi?id=225426
Summary
Add SPI to restrict networking to a set of hosts
Alex Christensen
Reported
2021-05-05 17:14:40 PDT
Add SPI to restrict networking to a set of hosts
Attachments
Patch
(31.09 KB, patch)
2021-05-05 17:18 PDT
,
Alex Christensen
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Patch
(31.35 KB, patch)
2021-05-05 17:44 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(31.27 KB, patch)
2021-05-05 17:57 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2021-05-05 17:18:43 PDT
Created
attachment 427826
[details]
Patch
Alex Christensen
Comment 2
2021-05-05 17:42:42 PDT
rdar://77571521
Alex Christensen
Comment 3
2021-05-05 17:44:58 PDT
Created
attachment 427831
[details]
Patch
Alex Christensen
Comment 4
2021-05-05 17:57:46 PDT
Created
attachment 427833
[details]
Patch
Tim Horton
Comment 5
2021-05-11 11:28:15 PDT
Comment on
attachment 427833
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=427833&action=review
> Source/WebCore/page/Page.cpp:3307 > + if (!url.protocolIsInHTTPFamily() && !url.protocolIs("ws") && !url.protocolIs("wss")) > + return true;
Do we not have a helper somewhere else that is like "the host in this is a host in the HTTP sense"? It seems weird for Page to know this
Alex Christensen
Comment 6
2021-05-11 12:31:11 PDT
Comment on
attachment 427833
[details]
Patch We don't. This needs to be more than HTTP. This needs to be schemes that access the network, which includes http, https, ws, and wss.
EWS
Comment 7
2021-05-11 12:47:59 PDT
Committed
r277336
(
237595@main
): <
https://commits.webkit.org/237595@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 427833
[details]
.
Radar WebKit Bug Importer
Comment 8
2021-05-11 12:48:23 PDT
<
rdar://problem/77857370
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug