Bug 225422 - [GStreamer] REGRESSION(r277031): imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html is failing
Summary: [GStreamer] REGRESSION(r277031): imported/w3c/web-platform-tests/encrypted-me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alicia Boya García
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-05 16:48 PDT by Diego Pino
Modified: 2021-05-06 14:01 PDT (History)
4 users (show)

See Also:


Attachments
Patch for landing (1.68 KB, patch)
2021-05-06 04:41 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff
Patch for landing (2.10 KB, patch)
2021-05-06 13:07 PDT, Alicia Boya García
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2021-05-05 16:48:21 PDT
The test is failing since r277031:

  imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https.html [ Failure ]

https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fencrypted-media%2Fclearkey-mp4-playback-temporary-encrypted-clear.https.html&platform=GTK&platform=WPE

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r277041%20%281578%29/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear.https-actual.txt
@@ -1,5 +1,3 @@
 
-Harness Error (TIMEOUT), message = null
+PASS org.w3.clearkey, temporary, mp4, playback, single key, encrypted then clear content
 
-TIMEOUT org.w3.clearkey, temporary, mp4, playback, single key, encrypted then clear content Test timed out
-
Comment 1 Alicia Boya García 2021-05-06 04:28:27 PDT
TIMEOUT turned into PASS, the best kind of regression!
Comment 2 Alicia Boya García 2021-05-06 04:41:53 PDT
Created attachment 427870 [details]
Patch for landing
Comment 3 EWS 2021-05-06 05:08:04 PDT
Committed r277082 (237385@main): <https://commits.webkit.org/237385@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427870 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-06 05:09:14 PDT
<rdar://problem/77602655>
Comment 5 Alicia Boya García 2021-05-06 13:07:25 PDT
Reopening to attach new patch.
Comment 6 Alicia Boya García 2021-05-06 13:07:28 PDT
Created attachment 427925 [details]
Patch for landing
Comment 7 Alicia Boya García 2021-05-06 13:09:49 PDT
Sent another patch to correct TestExpectations (the previous one only adjusted -expected.txt).

Still, while looking at it I noticed that only the first second of video (the encrypted part) actually shows in the video widget, it seems to freeze for the rest (I would assume the non-encrypted part), even if the test ends up passing. That looks like a bug, whether it's a regression or not.
Comment 8 EWS 2021-05-06 14:01:11 PDT
Committed r277119 (237417@main): <https://commits.webkit.org/237417@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427925 [details].