Bug 225411 - EWS bubbles should show current status after pressing 'Retry failed builds' button
Summary: EWS bubbles should show current status after pressing 'Retry failed builds' b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-05 13:23 PDT by Devin Rousso
Modified: 2021-05-06 11:43 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2021-05-05 16:40 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff
[fast-cq] Patch (1.85 KB, patch)
2021-05-05 17:25 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-05-05 13:23:28 PDT
IMO accessing "what is it doing now" is more important/useful than "what did it do before".  Right now I don't know whether a "retry failures" patch is successfully/correctly in the bot's queue or if the bot is stuck or some other thing.
Comment 1 Aakash Jain 2021-05-05 16:40:41 PDT
Created attachment 427817 [details]
Patch
Comment 2 Aakash Jain 2021-05-05 17:24:10 PDT
To clarify the request here, even after clicking 'Retry failed builds' button, for the queue which were retried, the status-bubble keep linking to old builds (and keep showing old build info in hover-over message). This becomes confusing to some users, especially when the new build isn't started soon. A better way would be to not show old build info anymore, and link to the queue (in which the retry request is queued) instead of linking to old build.
Comment 3 Aakash Jain 2021-05-05 17:25:08 PDT
Created attachment 427830 [details]
[fast-cq] Patch
Comment 4 EWS 2021-05-06 11:34:21 PDT
Committed r277103 (237405@main): <https://commits.webkit.org/237405@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427830 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-06 11:35:16 PDT
<rdar://problem/77617611>
Comment 6 Aakash Jain 2021-05-06 11:43:21 PDT
Deployed this change on the server.