Bug 225405 - Sampled Page Top Color: tie into existing TCADA/RLTT systems so that the value is kept in sync with painting
Summary: Sampled Page Top Color: tie into existing TCADA/RLTT systems so that the valu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-05 12:41 PDT by Devin Rousso
Modified: 2021-05-05 15:23 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.60 KB, patch)
2021-05-05 12:46 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2021-05-05 12:41:44 PDT 
.
Comment 1 Devin Rousso 2021-05-05 12:46:44 PDT 
Created attachment 427792 [details]
Patch
Comment 2 Tim Horton 2021-05-05 12:53:57 PDT 
Comment on attachment 427792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427792&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6469
> +    send(Messages::WebPageProxy::SampledPageTopColorChanged(m_page->sampledPageTopColor()));

I don't understand why there's a non-transactional version of this? It should just dirty the transaction and be sent that way (so that it, again, is synchronized with the layer content in the transaction).
Comment 3 Devin Rousso 2021-05-05 12:56:10 PDT 
Comment on attachment 427792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427792&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6469
>> +    send(Messages::WebPageProxy::SampledPageTopColorChanged(m_page->sampledPageTopColor()));
> 
> I don't understand why there's a non-transactional version of this? It should just dirty the transaction and be sent that way (so that it, again, is synchronized with the layer content in the transaction).

This is only called inside `TiledCoreAnimationDrawingArea::updateRendering`.  This is also how `themeColor` and `pageExtendedBackgroundColor` do it.  It was my understanding that this is how it's done for macOS?  Am I mistaken?
Comment 4 Tim Horton 2021-05-05 13:09:59 PDT 
(In reply to Devin Rousso from comment #3)
> Comment on attachment 427792 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427792&action=review
> 
> >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6469
> >> +    send(Messages::WebPageProxy::SampledPageTopColorChanged(m_page->sampledPageTopColor()));
> > 
> > I don't understand why there's a non-transactional version of this? It should just dirty the transaction and be sent that way (so that it, again, is synchronized with the layer content in the transaction).
> 
> This is only called inside `TiledCoreAnimationDrawingArea::updateRendering`.
> This is also how `themeColor` and `pageExtendedBackgroundColor` do it.  It
> was my understanding that this is how it's done for macOS?  Am I mistaken?

Oh oh oh, yes, this is for non-transactional WebKit :)
Comment 5 EWS 2021-05-05 15:22:43 PDT 
Committed r277045 (237357@main): <https://commits.webkit.org/237357@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427792 [details].
Comment 6 Radar WebKit Bug Importer 2021-05-05 15:23:13 PDT 
<rdar://problem/77578428>