Bug 225405 – Sampled Page Top Color: tie into existing TCADA/RLTT systems so that the value is kept in sync with painting

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Devin Rousso]

.

[Devin Rousso]

Created attachment 427792 [details]
Patch

[Tim Horton]

Comment on attachment 427792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427792&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6469
> +    send(Messages::WebPageProxy::SampledPageTopColorChanged(m_page->sampledPageTopColor()));

I don't understand why there's a non-transactional version of this? It should just dirty the transaction and be sent that way (so that it, again, is synchronized with the layer content in the transaction).

[Devin Rousso]

Comment on attachment 427792 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427792&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6469
>> +    send(Messages::WebPageProxy::SampledPageTopColorChanged(m_page->sampledPageTopColor()));
> 
> I don't understand why there's a non-transactional version of this? It should just dirty the transaction and be sent that way (so that it, again, is synchronized with the layer content in the transaction).

This is only called inside `TiledCoreAnimationDrawingArea::updateRendering`.  This is also how `themeColor` and `pageExtendedBackgroundColor` do it.  It was my understanding that this is how it's done for macOS?  Am I mistaken?

[Tim Horton]

(In reply to Devin Rousso from comment #3)
> Comment on attachment 427792 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427792&action=review
> 
> >> Source/WebKit/WebProcess/WebPage/WebPage.cpp:6469
> >> +    send(Messages::WebPageProxy::SampledPageTopColorChanged(m_page->sampledPageTopColor()));
> > 
> > I don't understand why there's a non-transactional version of this? It should just dirty the transaction and be sent that way (so that it, again, is synchronized with the layer content in the transaction).
> 
> This is only called inside `TiledCoreAnimationDrawingArea::updateRendering`.
> This is also how `themeColor` and `pageExtendedBackgroundColor` do it.  It
> was my understanding that this is how it's done for macOS?  Am I mistaken?

Oh oh oh, yes, this is for non-transactional WebKit :)

[EWS]

Committed r277045 (237357@main): <https://commits.webkit.org/237357@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427792 [details].

[Radar WebKit Bug Importer]

<rdar://problem/77578428>