Bug 225396 – [GPUP] Reduce MediaPlayer polling frequency when possible

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

When `currentMediaTimeDidChange` is supported by the media player, use it push currentTime updates instead of polling at a fixed frequency.

[Radar WebKit Bug Importer]

<rdar://problem/77562643>

[Eric Carlson]

Created attachment 427778 [details]
Patch

[Peng Liu]

Comment on attachment 427778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427778&action=review

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:109
> +    virtual bool setCurrentTimeDidChangeCallback(MediaPlayer::CurrentTimeDidChangeCallback&&) { return false; }

Nit. The return value indicates whether the player supports time change callback, right?
It works, but looks a little strange. Maybe adding an interface like "supportsTimeChangeCallback()" is better? I am not sure.

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.messages.in:42
> +    CurrentTimeChanged(MediaTime mediaTime, MonotonicTime wallTime)

Nit. `wallTime` is interesting here. :-)
Maybe `queryTime` is better?

[EWS]

Found 30 new test failures: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html, compositing/iframes/border-uneven-radius-composited-frame.html, compositing/video/video-reflection.html, fast/canvas/webgl/texImage2D-video-flipY-true.html, http/tests/media/media-play-stream-chunked-icy.html, http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html, http/tests/media/modern-media-controls/pip-support/pip-support-live-broadcast.html, http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html, http/tests/media/modern-media-controls/skip-back-support/skip-back-support-live-broadcast.html, http/tests/media/modern-media-controls/status-support/status-support-live-broadcast.html ...

[Eric Carlson]

Created attachment 427812 [details]
Patch for landing

[Eric Carlson]

Created attachment 427908 [details]
Patch for landing

[EWS]

Committed r277116 (237414@main): <https://commits.webkit.org/237414@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427908 [details].