Bug 225393 - USE_64KB_PAGE_BLOCK build option is broken
Summary: USE_64KB_PAGE_BLOCK build option is broken
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Reported: 2021-05-05 05:30 PDT by Michael Catanzaro
Modified: 2021-05-05 06:39 PDT (History)
7 users (show)

See Also:

Patch (1.13 KB, patch)
2021-05-05 05:31 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2021-05-05 05:30:42 PDT
This option has been broken since I added it in bug #217989. It does properly configure the various JSC and bmalloc options, but doesn't get passed on from CMake to the actual build, so we wind up configuring a 4 KB max page size in PageBlock.h. Oops.
Comment 1 Michael Catanzaro 2021-05-05 05:31:29 PDT
Created attachment 427759 [details]
Comment 2 Michael Catanzaro 2021-05-05 05:42:52 PDT
CC: Adrian, this would be a good backport for 2.32.
Comment 3 EWS 2021-05-05 06:39:18 PDT
Committed r277015 (237331@main): <https://commits.webkit.org/237331@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427759 [details].