WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
225393
USE_64KB_PAGE_BLOCK build option is broken
https://bugs.webkit.org/show_bug.cgi?id=225393
Summary
USE_64KB_PAGE_BLOCK build option is broken
Michael Catanzaro
Reported
2021-05-05 05:30:42 PDT
This option has been broken since I added it in
bug #217989
. It does properly configure the various JSC and bmalloc options, but doesn't get passed on from CMake to the actual build, so we wind up configuring a 4 KB max page size in PageBlock.h. Oops.
Attachments
Patch
(1.13 KB, patch)
2021-05-05 05:31 PDT
,
Michael Catanzaro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Michael Catanzaro
Comment 1
2021-05-05 05:31:29 PDT
Created
attachment 427759
[details]
Patch
Michael Catanzaro
Comment 2
2021-05-05 05:42:52 PDT
CC: Adrian, this would be a good backport for 2.32.
EWS
Comment 3
2021-05-05 06:39:18 PDT
Committed
r277015
(
237331@main
): <
https://commits.webkit.org/237331@main
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 427759
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug