RESOLVED FIXED 225390
Use WeakHashSet instead of HashSet of raw pointers in Document and SVGDocumentExtensions 
https://bugs.webkit.org/show_bug.cgi?id=225390
Summary Use WeakHashSet instead of HashSet of raw pointers in Document and SVGDocumen...
Ryosuke Niwa
Reported 2021-05-05 03:22:32 PDT
In Document and SVGDocumentExtensions, there are a few HashSet of elements. Use WeakHashSet instead.
Attachments
Patch (26.56 KB, patch)
2021-05-05 03:32 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-05-05 03:32:28 PDT
Created attachment 427751 [details] Patch
Ryosuke Niwa
Comment 2 2021-05-05 03:33:57 PDT
Comment on attachment 427751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427751&action=review > Source/WebCore/svg/SVGDocumentExtensions.h:88 > HashMap<SVGElement*, std::unique_ptr<HashSet<SVGElement*>>> m_elementDependencies; I'd address this in a separate patch since it's a bit more involved.
EWS
Comment 3 2021-05-05 06:14:35 PDT
Committed r277013 (237329@main): <https://commits.webkit.org/237329@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427751 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-05 06:15:18 PDT
<rdar://problem/77554370>
Note You need to log in before you can comment on or make changes to this bug.