Bug 225380 - copy/paste error in Recorder::canAppendItemOfType
Summary: copy/paste error in Recorder::canAppendItemOfType
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-04 21:02 PDT by Cameron McCormack (:heycam)
Modified: 2021-05-05 15:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.53 KB, patch)
2021-05-04 21:45 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-05-04 21:02:41 PDT 
https://webkit-search.igalia.com/webkit/rev/a221ff61ad355d85ae240e1313c5906779f00692/Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp#131

>         || type == ItemType::ApplyStrokePattern || type == ItemType::ApplyStrokePattern

One of these should presumably be ApplyFillPattern.
Comment 1 Wenson Hsieh 2021-05-04 21:03:56 PDT 
Good catch.
Comment 2 Cameron McCormack (:heycam) 2021-05-04 21:45:31 PDT 
Created attachment 427731 [details]
Patch
Comment 3 Cameron McCormack (:heycam) 2021-05-04 21:45:49 PDT 
(Happy to add a test if needed.)
Comment 4 EWS 2021-05-05 15:30:41 PDT 
Committed r277046 (237358@main): <https://commits.webkit.org/237358@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427731 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-05 15:31:15 PDT 
<rdar://problem/77578785>