...
<rdar://problem/75863443>
Created attachment 427716 [details] Patch for EWS
Created attachment 427790 [details] Patch
Comment on attachment 427790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427790&action=review > Source/WebCore/rendering/RenderThemeMac.mm:414 > + if ([cell interiorBackgroundStyle] == NSBackgroundStyleEmphasized) Should also have a FIXME and an AppKit radar on all of this.
Created attachment 427801 [details] Patch for landing
Committed r277067 (237370@main): <https://commits.webkit.org/237370@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427801 [details].
Comment on attachment 427801 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=427801&action=review > Source/WebCore/rendering/RenderThemeMac.mm:423 > + auto cell = adoptNS([[NSButtonCell alloc] init]); > + [cell setBezelStyle:NSBezelStyleRounded]; > + [cell setHighlighted:YES]; > + > + NSColor *activeButtonTextColor; > + if ([cell interiorBackgroundStyle] == NSBackgroundStyleEmphasized) > + activeButtonTextColor = [NSColor alternateSelectedControlTextColor]; > + else > + activeButtonTextColor = [NSColor controlTextColor]; > + > + return semanticColorFromNSColor(activeButtonTextColor); Do we call this every time we paint a button? Can we cache it?
(In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 427801 [details] > Patch for landing > Do we call this every time we paint a button? Can we cache it? See the changelog :)