Bug 22536 - Regression - QtWebKit MinGW port build failure
Summary: Regression - QtWebKit MinGW port build failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-11-27 19:11 PST by Laszlo Gombos
Modified: 2008-11-28 10:51 PST (History)
2 users (show)

See Also:

Attachments
Fix (1.71 KB, patch)
2008-11-27 19:21 PST, Laszlo Gombos 		vestbo: review-
Details | Formatted Diff | Diff
Revised patch based on comment #4 (2.29 KB, patch)
2008-11-28 09:14 PST, Laszlo Gombos 		vestbo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2008-11-27 19:11:55 PST 
Build failure in QtWebKit using MinGW port - I have seen the failure on Win using MinGW, but it could inpact other Qt platforms as well. 

Regression introduced in Changeset 36623 and inpacted both the wx and Qt port. Regression in wx port is fixed in Changeset 36717, but QT WebKit regression is still there.
Comment 1 Mark Rowe (bdash) 2008-11-27 19:15:53 PST 
It would be more useful if you included some information about what the failure is.
Comment 2 Laszlo Gombos 2008-11-27 19:21:58 PST 
Created attachment 25563 [details]
Fix
Comment 3 Laszlo Gombos 2008-11-27 19:25:10 PST 
Mark, compiler under MinGW ends up trying to compile .h files, because they are listed as SOURCE files in the WebCore.pro. DO not have the actual error message handy.
Comment 4 Tor Arne Vestbø 2008-11-28 08:41:57 PST 
Maybe add the removed headers to HEADERS?
Comment 5 Laszlo Gombos 2008-11-28 09:14:34 PST 
Created attachment 25574 [details]
Revised patch based on comment #4

Instead of removing the headers in question from SOURCES, I moved them to HEADERS.
Comment 6 Tor Arne Vestbø 2008-11-28 10:51:48 PST 
Good stuff! Landed in r38832