Bug 225336 - Inclusive terminology: Change 'master key' to 'main key'
Summary: Inclusive terminology: Change 'master key' to 'main key'
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-03 16:40 PDT by Brent Fulgham
Modified: 2021-09-20 09:51 PDT (History)
5 users (show)

See Also:

Attachments
Patch (8.39 KB, patch)
2021-05-03 16:45 PDT, Brent Fulgham 		bfulgham: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-05-03 16:40:20 PDT 
In support of using more inclusive language in WebKit, we should switch the term 'Master Key' to 'Main Key'.
Comment 1 Brent Fulgham 2021-05-03 16:44:07 PDT 
<rdar://problem/70995449>
Comment 2 Brent Fulgham 2021-05-03 16:45:24 PDT 
Created attachment 427618 [details]
Patch
Comment 3 Alexey Proskuryakov 2021-05-03 17:21:49 PDT 
Comment on attachment 427618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427618&action=review

> Source/WebCore/ChangeLog:9
> +        Change the text 'Master Key' to 'Main Key' in messages and labels.

Will this invalidate all data encrypted with this key? What exactly will the user impact be?
Comment 4 Brent Fulgham 2021-05-03 17:31:48 PDT 
Comment on attachment 427618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427618&action=review

>> Source/WebCore/ChangeLog:9
>> +        Change the text 'Master Key' to 'Main Key' in messages and labels.
> 
> Will this invalidate all data encrypted with this key? What exactly will the user impact be?

I don't think this will invalidate the key data, but looking further it does seem like we would lose access to the existing keychain, so we probably need a migration step.
Comment 5 Brent Fulgham 2021-09-20 09:50:57 PDT 
After review, it was decided that this change was not needed.