RESOLVED FIXED Bug 225308
Fix syntax error message for AUTOPLUSPLUS token. 
https://bugs.webkit.org/show_bug.cgi?id=225308
Summary Fix syntax error message for AUTOPLUSPLUS token.
Mark Lam
Reported 2021-05-03 08:33:05 PDT
These tokens don't current add any value, but actually produces a bug where a SyntaxError due to mis-applied ++ operator mentions "--" instead of "++". rdar://76830934
Attachments
proposed patch. (6.10 KB, patch)
2021-05-03 08:47 PDT, Mark Lam 		mark.lam: review-
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (3.91 KB, patch)
2021-05-03 14:47 PDT, Mark Lam 		saam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2021-05-03 08:47:56 PDT
Created attachment 427563 [details] proposed patch.
Mark Lam
Comment 2 2021-05-03 10:36:40 PDT
Comment on attachment 427563 [details] proposed patch. I'm gonna investigate why there are EWS failures.
Mark Lam
Comment 3 2021-05-03 14:28:49 PDT
I was wrong about AUTOPLUSPLUS not being needed. It’s needed to distinquish this: ``` statement ++ stuff ``` from this: ``` statement ++stuff ``` AUTOPLUSPLUS tells us that that there’s a `\n` there, which tells us that the ++ is a prefix for the next token, not a postfix for the last one. So, the real bug is that the SyntaxError message needs to take into account AUTOPLUSPLUS.
Mark Lam
Comment 4 2021-05-03 14:47:08 PDT
Created attachment 427605 [details] proposed patch.
Mark Lam
Comment 5 2021-05-03 19:38:35 PDT
Thanks for the review. The AS Mac failures are not related. Landed in r276942: <http://trac.webkit.org/r276942>.
Note You need to log in before you can comment on or make changes to this bug.