Bug 225285 - Support reftests using DisplayP3 backing stores rather than sRGB to enable testing non-sRGB functionality
Summary: Support reftests using DisplayP3 backing stores rather than sRGB to enable te...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-02 17:49 PDT by Sam Weinig
Modified: 2021-05-09 17:50 PDT (History)
2 users (show)

See Also:

Attachments
WIP (only supports non-composited WebKitLegacy macOS) (21.78 KB, patch)
2021-05-02 17:52 PDT, Sam Weinig 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-02 17:49:38 PDT 
Support reftests using DisplayP3 backing stores rather than sRGB to enable testing non-sRGB functionality
Comment 1 Sam Weinig 2021-05-02 17:52:18 PDT 
Created attachment 427533 [details]
WIP (only supports non-composited WebKitLegacy macOS)
Comment 2 Sam Weinig 2021-05-02 19:28:25 PDT 
For modern WebKit and composited WebKitLegacy content the issue is that CGWindowListCreateImage() doesn't seem to be return a CGImageRef with the right color space even though the window has a DisplayP3 color space on it. 

I will check with the window server and CA folks to see if this is expected and/or there is any work around.

If there isn't, we could make this new flag incompatible with compositing and use the FrameSnapshotting code when testing non-sRGB, but that seems less than ideal.
Comment 3 Radar WebKit Bug Importer 2021-05-09 17:50:15 PDT 
<rdar://problem/77722485>