Bug 225283 - glib-genmarshal generated BrowserMarshal.[ch] contained referenced to sourcedir
Summary: glib-genmarshal generated BrowserMarshal.[ch] contained referenced to sourcedir
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-02 13:06 PDT by Khem Raj
Modified: 2021-05-09 12:12 PDT (History)
7 users (show)

See Also:

Attachments
fix-v1 (1.60 KB, patch)
2021-05-02 13:09 PDT, Khem Raj 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Khem Raj 2021-05-02 13:06:06 PDT 
There are references to build time source folder in comments in generated sourcecode BrowserMarshal.c/BrowserMarshal.h, these sources do end up in debug packages (ipks/debs/rpms) which ends up breaking reproducible builds. We can use --skip-source cmdline option to glib-genmarshal to not including the source path in the generated header/source files.
Comment 1 Khem Raj 2021-05-02 13:09:03 PDT 
Created attachment 427531 [details]
fix-v1
Comment 2 Carlos Alberto Lopez Perez 2021-05-09 11:45:08 PDT 
Comment on attachment 427531 [details]
fix-v1

thanks!
Comment 3 EWS 2021-05-09 12:11:29 PDT 
Committed r277252 (237521@main): <https://commits.webkit.org/237521@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427531 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-09 12:12:15 PDT 
<rdar://problem/77718052>