Bug 225274 - editing/selection/ios/become-key-window-when-focusing-editable-area.html is timing out
Summary: editing/selection/ios/become-key-window-when-focusing-editable-area.html is t...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-01 14:01 PDT by Wenson Hsieh
Modified: 2021-05-03 11:35 PDT (History)
5 users (show)

See Also:

Attachments
For EWS (2.84 KB, patch)
2021-05-01 14:03 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Patch (4.63 KB, patch)
2021-05-01 15:45 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Add a comment (4.87 KB, patch)
2021-05-01 17:41 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2021-05-01 14:01:23 PDT 
rdar://77042575
Comment 1 Wenson Hsieh 2021-05-01 14:03:22 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2021-05-01 15:45:14 PDT 
Created attachment 427514 [details]
Patch
Comment 3 Sam Weinig 2021-05-01 17:29:22 PDT 
Comment on attachment 427514 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427514&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:251
> +        if (!m_otherWindow) {
> +            m_otherWindow = adoptNS([[UIWindow alloc] initWithWindowScene:m_window.windowScene]);
> +            [m_otherWindow setFrame:CGRectMake(-1, -1, 1, 1)];
> +        }
> +        [m_otherWindow setHidden:NO];
> +        [m_otherWindow makeKeyWindow];

This seems mysterious enough to warrant a comment explaining what is going on here.
Comment 4 Wenson Hsieh 2021-05-01 17:41:20 PDT 
Created attachment 427516 [details]
Add a comment
Comment 5 EWS 2021-05-03 11:35:31 PDT 
Committed r276912 (237256@main): <https://commits.webkit.org/237256@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427516 [details].