Bug 225272 - Move PixelFormat into its own file
Summary: Move PixelFormat into its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-01 09:55 PDT by Sam Weinig
Modified: 2021-05-01 20:40 PDT (History)
8 users (show)

See Also:

Attachments
Patch (8.17 KB, patch)
2021-05-01 09:56 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2021-05-01 09:55:04 PDT 
Move PixelFormat into its own file
Comment 1 Sam Weinig 2021-05-01 09:56:37 PDT 
Created attachment 427505 [details]
Patch
Comment 2 Darin Adler 2021-05-01 20:10:01 PDT 
Comment on attachment 427505 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427505&action=review

> Source/WebCore/platform/graphics/PixelFormat.h:37
> +enum class PixelFormat : uint8_t {
> +    RGBA8,
> +    BGRA8,
> +    RGB10,
> +    RGB10A8,
> +};

When there is a short list like that, I love to do it horizontally instead of vertically, but not sure you feel the same.
Comment 3 EWS 2021-05-01 20:39:15 PDT 
Committed r276881 (237227@main): <https://commits.webkit.org/237227@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427505 [details].
Comment 4 Radar WebKit Bug Importer 2021-05-01 20:40:19 PDT 
<rdar://problem/77425875>