RESOLVED FIXED Bug 225269
Consider removing imported/w3c/canvas and canvas/philip 
https://bugs.webkit.org/show_bug.cgi?id=225269
Summary Consider removing imported/w3c/canvas and canvas/philip
Sam Weinig
Reported 2021-05-01 08:31:42 PDT
It looks like the layout tests in imported/w3c/canvas and canvas/philip are an out of date subset of the tests in imported/w3c/web-platform-tests/html/canvas/element. I think we should consider removing them to avoid the unnecessary overhead during testing.
Attachments
Patch (3.43 MB, patch)
2021-05-01 10:48 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Part 1 (just canvas/philip) (1.55 MB, patch)
2021-05-01 17:31 PDT, Sam Weinig 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2021-05-01 08:32:25 PDT
Simon/Dean, do either of you have opinions on this?
Sam Weinig
Comment 2 2021-05-01 08:42:09 PDT
I would like to come up with a way to figure out which tests are actually identical, but the changes in test runners between the 3 copies makes this harder than one would like.
Simon Fraser (smfr)
Comment 3 2021-05-01 10:21:15 PDT
I support their removal.
Sam Weinig
Comment 4 2021-05-01 10:48:57 PDT
Created attachment 427507 [details] Patch
Sam Weinig
Comment 5 2021-05-01 16:14:23 PDT
3.2 mb may be to big for the bots.
Sam Weinig
Comment 6 2021-05-01 17:31:01 PDT
Created attachment 427515 [details] Part 1 (just canvas/philip)
Sam Weinig
Comment 7 2021-05-01 17:31:45 PDT
Breaking this in two to see if that makes the bots any happier.
Sam Weinig
Comment 8 2021-05-02 08:46:27 PDT
(In reply to Sam Weinig from comment #7) > Breaking this in two to see if that makes the bots any happier. Alas, they are not. It seems there is something in the patch file that is making them unhappy. patching file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html Hunk #1 FAILED at 1. File LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html is not empty after patch, as expected 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html.rej
EWS
Comment 9 2021-05-02 09:27:41 PDT
Tools/Scripts/svn-apply failed to apply attachment 427515 [details] to trunk. Please resolve the conflicts and upload a new patch.
Sam Weinig
Comment 10 2021-05-02 09:37:27 PDT
Part 1 landed in https://trac.webkit.org/changeset/276884/webkit.
Sam Weinig
Comment 11 2021-05-02 09:45:59 PDT
Part 2 landed in https://trac.webkit.org/changeset/276885/webkit.
Radar WebKit Bug Importer
Comment 12 2021-05-02 09:47:14 PDT
<rdar://problem/77435676>
Aakash Jain
Comment 13 2021-05-03 03:40:01 PDT
(In reply to Sam Weinig from comment #8) > (In reply to Sam Weinig from comment #7) > > Breaking this in two to see if that makes the bots any happier. > > Alas, they are not. It seems there is something in the patch file that is > making them unhappy. Can you please file a bug about this (for our tooling)?
Note You need to log in before you can comment on or make changes to this bug.