It looks like the layout tests in imported/w3c/canvas and canvas/philip are an out of date subset of the tests in imported/w3c/web-platform-tests/html/canvas/element.
I think we should consider removing them to avoid the unnecessary overhead during testing.
Simon/Dean, do either of you have opinions on this?
I would like to come up with a way to figure out which tests are actually identical, but the changes in test runners between the 3 copies makes this harder than one would like.
I support their removal.
Created attachment 427507 [details]
3.2 mb may be to big for the bots.
Created attachment 427515 [details]
Part 1 (just canvas/philip)
Breaking this in two to see if that makes the bots any happier.
(In reply to Sam Weinig from comment #7)
> Breaking this in two to see if that makes the bots any happier.
Alas, they are not. It seems there is something in the patch file that is making them unhappy.
patching file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html
Hunk #1 FAILED at 1.
File LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html is not empty after patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html.rej
Tools/Scripts/svn-apply failed to apply attachment 427515 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Part 1 landed in https://trac.webkit.org/changeset/276884/webkit.
Part 2 landed in https://trac.webkit.org/changeset/276885/webkit.
(In reply to Sam Weinig from comment #8)
> (In reply to Sam Weinig from comment #7)
> > Breaking this in two to see if that makes the bots any happier.
> Alas, they are not. It seems there is something in the patch file that is
> making them unhappy.
Can you please file a bug about this (for our tooling)?