Bug 225264 - Add some missing exception checks before some jsCasts.
Summary: Add some missing exception checks before some jsCasts.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 19:58 PDT by Mark Lam
Modified: 2021-05-03 08:55 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch. (13.33 KB, patch)
2021-04-30 20:23 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (13.33 KB, patch)
2021-04-30 20:25 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (13.33 KB, patch)
2021-04-30 20:51 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-04-30 19:58:19 PDT 
rdar://77381608
Comment 1 Mark Lam 2021-04-30 20:23:56 PDT 
Created attachment 427485 [details]
proposed patch.
Comment 2 Mark Lam 2021-04-30 20:25:07 PDT 
Created attachment 427486 [details]
proposed patch.
Comment 3 Mark Lam 2021-04-30 20:27:29 PDT 
Comment on attachment 427486 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=427486&action=review

> Source/JavaScriptCore/ChangeLog:12
> +        time of the jsCast.  On ASSERTs are not enabled, this will be a no-op.  All clients

/On/If/.  Will fix before landing.
Comment 4 Mark Lam 2021-04-30 20:51:25 PDT 
Created attachment 427488 [details]
proposed patch.
Comment 5 EWS 2021-05-03 08:55:02 PDT 
Committed r276900 (237246@main): <https://commits.webkit.org/237246@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427488 [details].