Bug 225260 – App highlight UI should be disabled when selecting text in image overlays

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Wenson Hsieh]

rdar://77359313

[Wenson Hsieh]

Created attachment 427471 [details]
Patch

[Tim Horton]

Comment on attachment 427471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427471&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3571
> +        // FIXME: It doesn't seem like this codepath is exercised, since UIKit only asks for the action target for custom actions
> +        // added via -[UIMenuController setMenuItems:]. Can we remove this check?

Yikes, good catch.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3769
> +        return state.selectionIsRange && !state.isContentEditable && !state.selectionIsRangeInsideImageOverlay ? self : nil;

Please factor this out as discussed.

> Tools/ChangeLog:21
> +        Add support for a new `TestOption` that enables app higlights. See the new layout test for more information.

sp. "highlights"

[Wenson Hsieh]

Comment on attachment 427471 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427471&action=review

Thanks for the review!

>> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3769
>> +        return state.selectionIsRange && !state.isContentEditable && !state.selectionIsRangeInsideImageOverlay ? self : nil;
> 
> Please factor this out as discussed.

👍🏻

>> Tools/ChangeLog:21
>> +        Add support for a new `TestOption` that enables app higlights. See the new layout test for more information.
> 
> sp. "highlights"

Whoops, fixed!

[Wenson Hsieh]

Created attachment 427482 [details]
For EWS

[EWS]

Committed r276871 (237217@main): <https://commits.webkit.org/237217@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427482 [details].