Bug 225259 - [iOS] Crash when tapping fields on cycle.travel
Summary: [iOS] Crash when tapping fields on cycle.travel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aditya Keerthi
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 16:56 PDT by Aditya Keerthi
Modified: 2021-05-03 08:58 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.90 KB, patch)
2021-04-30 18:06 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Patch (16.88 KB, patch)
2021-04-30 19:48 PDT, Aditya Keerthi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aditya Keerthi 2021-04-30 16:56:16 PDT 
Steps To Reproduce:
1. Visit https://cycle.travel/map/mobile?debug=1
2. Tap on the From or To field.
3. Observe page reload or “A problem repeatedly occurred”.
Comment 1 Aditya Keerthi 2021-04-30 16:56:36 PDT 
<rdar://problem/77386417>
Comment 2 Aditya Keerthi 2021-04-30 18:06:54 PDT 
Created attachment 427475 [details]
Patch
Comment 3 Wenson Hsieh 2021-04-30 18:23:08 PDT 
Comment on attachment 427475 [details]
Patch

r=mews
Comment 4 Tim Horton 2021-04-30 18:24:06 PDT 
Comment on attachment 427475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427475&action=review

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:3080
> +Optional<FocusedElementInformation> WebPage::getFocusedElementInformation()

if it's not out-arg-y, this should not have a get- prefix
Comment 5 Aditya Keerthi 2021-04-30 19:48:44 PDT 
Created attachment 427483 [details]
Patch
Comment 6 EWS 2021-05-03 08:58:37 PDT 
Committed r276901 (237247@main): <https://commits.webkit.org/237247@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427483 [details].