Bug 225254 - [Cocoa] Calling into -[AVPlayerItem currentTime] is very expensive
Summary: [Cocoa] Calling into -[AVPlayerItem currentTime] is very expensive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks: 225262
  Show dependency tree / graph
 
Reported: 2021-04-30 15:22 PDT by Jer Noble
Modified: 2021-06-28 14:07 PDT (History)
8 users (show)

See Also:

Attachments
Patch (7.14 KB, patch)
2021-04-30 15:27 PDT, Jer Noble 		eric.carlson: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (7.09 KB, patch)
2021-04-30 17:06 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2021-04-30 15:22:04 PDT 
[Cocoa] Calling into -[AVPlayerItem currentTime] is very expensive
Comment 1 Jer Noble 2021-04-30 15:27:18 PDT 
Created attachment 427458 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-04-30 15:28:08 PDT 
<rdar://problem/77401450>
Comment 3 Eric Carlson 2021-04-30 15:36:55 PDT 
Comment on attachment 427458 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427458&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1109
> +    auto currentTimeInterval = CMTimeMake(1, 10);

Do we need this local variable?
Comment 4 Jer Noble 2021-04-30 17:06:32 PDT 
Created attachment 427470 [details]
Patch for landing
Comment 5 EWS 2021-04-30 19:11:59 PDT 
Committed r276870 (237216@main): <https://commits.webkit.org/237216@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427470 [details].