Bug 225250 - Defend further against a PlatformCALayer's owner becoming null in PlatformCALayerCocoa::drawLayerContents.
Summary: Defend further against a PlatformCALayer's owner becoming null in PlatformCAL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 14:07 PDT by Cameron McCormack (:heycam)
Modified: 2021-04-30 18:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.35 KB, patch)
2021-04-30 14:50 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff
Patch (2.39 KB, patch)
2021-04-30 14:50 PDT, Cameron McCormack (:heycam)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-04-30 14:07:26 PDT
At the end of PlatformCALayer::drawLayerContents, we null check layerContents for the platformCALayerShowRepaintCounter call but not the platformCALayerIncrementRepaintCount call.
Comment 1 Cameron McCormack (:heycam) 2021-04-30 14:16:21 PDT
<rdar://37608882>
Comment 2 Cameron McCormack (:heycam) 2021-04-30 14:50:02 PDT
Created attachment 427450 [details]
Patch
Comment 3 Cameron McCormack (:heycam) 2021-04-30 14:50:26 PDT
Created attachment 427452 [details]
Patch
Comment 4 EWS 2021-04-30 18:19:27 PDT
Committed r276867 (237213@main): <https://commits.webkit.org/237213@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427452 [details].