Bug 225246 - [LayoutTests] http/tests/css/object-fit-delayed-img-svg.html yields errors due to missing scripts
Summary: [LayoutTests] http/tests/css/object-fit-delayed-img-svg.html yields errors du...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Gambrell
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 13:45 PDT by Chris Gambrell
Modified: 2021-05-05 11:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (3.51 KB, patch)
2021-05-03 09:15 PDT, Chris Gambrell
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Gambrell 2021-04-30 13:45:57 PDT
http/tests/css/object-fit-delayed-img-svg.html shows errors in the error log due to the resource http/tests/css/resources/delayedCircle.php not existing. 

The reason this test is passing is because the test expectations are showing the image http/tests/css/resources/circle.svg which also does not exist. 

Error:
[php7:error] [pid 29911] [client 127.0.0.1:52198] script '/app/webkit/LayoutTests/http/tests/css/resources/delayedCircle.php' not found or unable to stat, referer: http://127.0.0.1:8000/css/object-fit-delayed-img-svg.html
Comment 1 Radar WebKit Bug Importer 2021-04-30 13:46:48 PDT
<rdar://problem/77397227>
Comment 2 Chris Gambrell 2021-04-30 13:47:19 PDT
Reached out to Antti Koivisto for clarity on the purpose of the test
Comment 3 Chris Gambrell 2021-05-03 09:15:21 PDT
Created attachment 427567 [details]
Patch
Comment 4 Jonathan Bedard 2021-05-05 10:45:13 PDT
Comment on attachment 427567 [details]
Patch

Clearly an improvement on the existing test, since it didn't test anything.
Comment 5 EWS 2021-05-05 11:12:33 PDT
Committed r277029 (237342@main): <https://commits.webkit.org/237342@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427567 [details].