Bug 225245 - [GPUP] Poll videoPlaybackQualityMetrics at the frequency is it accessed by script
Summary: [GPUP] Poll videoPlaybackQualityMetrics at the frequency is it accessed by sc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 13:42 PDT by Eric Carlson
Modified: 2021-05-03 14:56 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2021-04-30 14:31 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Patch (15.53 KB, patch)
2021-04-30 15:09 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2021-04-30 13:42:11 PDT 
Fetching videoPlaybackQualityMetrics is expensive, so don't update it every time cached state is updated.
Comment 1 Eric Carlson 2021-04-30 13:42:24 PDT 
rdar://77159589
Comment 2 Eric Carlson 2021-04-30 14:31:13 PDT 
Created attachment 427448 [details]
Patch
Comment 3 Jer Noble 2021-04-30 14:52:41 PDT 
Comment on attachment 427448 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427448&action=review

> Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:997
> +    static const double metricsAdvanceUpdate = 0.25;

Can we make this Seconds?
Comment 4 Eric Carlson 2021-04-30 15:09:57 PDT 
Created attachment 427457 [details]
Patch
Comment 5 EWS 2021-04-30 16:36:32 PDT 
Committed r276863 (237211@main): <https://commits.webkit.org/237211@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427457 [details].
Comment 6 Simon Fraser (smfr) 2021-04-30 20:46:01 PDT 
Comment on attachment 427457 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427457&action=review

> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:1186
> +    auto now = WallTime::now();

Is WallTime the right thing to use here, instead of MonotonicTime?
Comment 7 Eric Carlson 2021-05-03 14:56:34 PDT 
(In reply to Simon Fraser (smfr) from comment #6)
> Comment on attachment 427457 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427457&action=review
> 
> > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:1186
> > +    auto now = WallTime::now();
> 
> Is WallTime the right thing to use here, instead of MonotonicTime?

Good point, thanks.

I'll fix that in https://bugs.webkit.org/show_bug.cgi?id=225329.