Bug 225244 - [iOS] Make AccessibilityReduceMotion test case work on iOS
Summary: [iOS] Make AccessibilityReduceMotion test case work on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 225542
Blocks:
  Show dependency tree / graph
 
Reported: 2021-04-30 13:39 PDT by Brent Fulgham
Modified: 2021-05-07 16:03 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.49 KB, patch)
2021-05-05 20:29 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (7.58 KB, patch)
2021-05-06 13:28 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (8.56 KB, patch)
2021-05-06 18:05 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (8.44 KB, patch)
2021-05-07 12:11 PDT, Brent Fulgham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (8.43 KB, patch)
2021-05-07 12:37 PDT, Brent Fulgham 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (8.40 KB, patch)
2021-05-07 12:56 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (7.41 KB, patch)
2021-05-07 15:33 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (7.41 KB, patch)
2021-05-07 15:37 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-04-30 13:39:12 PDT 
New tests for Accessibility-related features were added in Bug 215664, but only for macOS. We support these same features on iOS, and should have test coverage.

This patch gets equivalent testing running on iOS.
Comment 1 Radar WebKit Bug Importer 2021-05-05 20:27:37 PDT 
<rdar://problem/77589455>
Comment 2 Brent Fulgham 2021-05-05 20:29:58 PDT 
Created attachment 427846 [details]
Patch
Comment 3 Brent Fulgham 2021-05-06 13:28:27 PDT 
Created attachment 427929 [details]
Patch
Comment 4 Per Arne Vollan 2021-05-06 14:39:17 PDT 
Comment on attachment 427929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427929&action=review

R=me.

> Tools/TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm:46
> +SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, libAccessibility, kAXSReduceMotionPreference, CFStringRef)

Should PAL be used here?
Comment 5 Brent Fulgham 2021-05-06 18:05:47 PDT 
Created attachment 427969 [details]
Patch
Comment 6 Per Arne Vollan 2021-05-07 12:03:54 PDT 
Comment on attachment 427969 [details]
Patch

R=me.
Comment 7 Brent Fulgham 2021-05-07 12:11:33 PDT 
Created attachment 428020 [details]
Patch for landing
Comment 8 Brent Fulgham 2021-05-07 12:37:51 PDT 
Created attachment 428023 [details]
Patch for landing
Comment 9 Brent Fulgham 2021-05-07 12:56:41 PDT 
Created attachment 428026 [details]
Patch for landing
Comment 10 EWS 2021-05-07 14:42:37 PDT 
Committed r277201 (237473@main): <https://commits.webkit.org/237473@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428026 [details].
Comment 11 Simon Fraser (smfr) 2021-05-07 14:55:43 PDT 
Comment on attachment 428026 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=428026&action=review

> Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:58
> +      <CommandLineArguments>
> +         <CommandLineArgument
> +            argument = "--gtest_filter=WebKit.AccessibilityReduceMotion"
> +            isEnabled = "YES">
> +         </CommandLineArgument>
> +      </CommandLineArguments>

Did you mean to commit this?
Comment 12 Simon Fraser (smfr) 2021-05-07 14:56:24 PDT 
Comment on attachment 428026 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=428026&action=review

> Source/WebKit/ChangeLog:10
> +        Reviewed by Per Arne Vollan.

This gives above the paragraph above.
Comment 13 Brent Fulgham 2021-05-07 15:20:33 PDT 
(In reply to Simon Fraser (smfr) from comment #11)
> Comment on attachment 428026 [details]
> Patch for landing
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=428026&action=review
> 
> > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:58
> > +      <CommandLineArguments>
> > +         <CommandLineArgument
> > +            argument = "--gtest_filter=WebKit.AccessibilityReduceMotion"
> > +            isEnabled = "YES">
> > +         </CommandLineArgument>
> > +      </CommandLineArguments>
> 
> Did you mean to commit this?

:-(
Comment 14 WebKit Commit Bot 2021-05-07 15:22:10 PDT 
Re-opened since this is blocked by bug 225542
Comment 15 Brent Fulgham 2021-05-07 15:33:27 PDT 
Created attachment 428043 [details]
Patch for landing
Comment 16 Brent Fulgham 2021-05-07 15:37:01 PDT 
Created attachment 428047 [details]
Patch for landing
Comment 17 EWS 2021-05-07 16:03:51 PDT 
Committed r277209 (237481@main): <https://commits.webkit.org/237481@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428047 [details].