Bug 225241 - [webkitcmpy] Better document inner-workings of identifier generation
Summary: [webkitcmpy] Better document inner-workings of identifier generation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 12:06 PDT by Jonathan Bedard
Modified: 2021-04-30 15:25 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.97 KB, patch)
2021-04-30 12:13 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (16.21 KB, patch)
2021-04-30 14:28 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2021-04-30 12:06:01 PDT 
Dean Johnson recommended adding more comments to the implementation details of webkitscmpy.
Comment 1 Jonathan Bedard 2021-04-30 12:13:23 PDT 
Created attachment 427440 [details]
Patch
Comment 2 Jonathan Bedard 2021-04-30 14:28:34 PDT 
Created attachment 427447 [details]
Patch
Comment 3 Dean Johnson 2021-04-30 14:39:28 PDT 
Comment on attachment 427447 [details]
Patch

Unofficial r+; LGTM.
Comment 4 dewei_zhu 2021-04-30 14:40:05 PDT 
Comment on attachment 427447 [details]
Patch

r=me
Comment 5 EWS 2021-04-30 15:24:22 PDT 
Committed r276856 (237207@main): <https://commits.webkit.org/237207@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427447 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-30 15:25:17 PDT 
<rdar://problem/77401337>