Bug 225225 - REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing
Summary: REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jiewen Tan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-30 01:01 PDT by Jiewen Tan
Modified: 2021-05-04 11:35 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.36 KB, patch)
2021-04-30 01:25 PDT, Jiewen Tan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jiewen Tan 2021-04-30 01:01:55 PDT 
REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing.
Comment 1 Jiewen Tan 2021-04-30 01:02:41 PDT 
rdar://77074618
Comment 2 Jiewen Tan 2021-04-30 01:25:00 PDT 
Created attachment 427400 [details]
Patch
Comment 3 youenn fablet 2021-05-03 02:37:44 PDT 
Comment on attachment 427400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489
> +    runPresenterInternal(transports);

Instead of introducing another virtual method, can we use something like:
if (isMock())
    return;
Comment 4 Jiewen Tan 2021-05-04 11:08:58 PDT 
Comment on attachment 427400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review

>> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489
>> +    runPresenterInternal(transports);
> 
> Instead of introducing another virtual method, can we use something like:
> if (isMock())
>     return;

The design of the testing infrastructure here is to make the authenticator manager unaware of whether or not it's mocking. That's why we have all kinds of different virtual methods.
Comment 5 Brent Fulgham 2021-05-04 11:16:45 PDT 
Comment on attachment 427400 [details]
Patch

r=me
Comment 6 Jiewen Tan 2021-05-04 11:25:05 PDT 
Comment on attachment 427400 [details]
Patch

Thanks Brent for r+ this patch.
Comment 7 EWS 2021-05-04 11:35:05 PDT 
Committed r276972 (237301@main): <https://commits.webkit.org/237301@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427400 [details].