Bug 225225 – REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Jiewen Tan]

REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing.

[Jiewen Tan]

rdar://77074618

[Jiewen Tan]

Created attachment 427400 [details]
Patch

[youenn fablet]

Comment on attachment 427400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review

> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489
> +    runPresenterInternal(transports);

Instead of introducing another virtual method, can we use something like:
if (isMock())
    return;

[Jiewen Tan]

Comment on attachment 427400 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review

>> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489
>> +    runPresenterInternal(transports);
> 
> Instead of introducing another virtual method, can we use something like:
> if (isMock())
>     return;

The design of the testing infrastructure here is to make the authenticator manager unaware of whether or not it's mocking. That's why we have all kinds of different virtual methods.

[Brent Fulgham]

Comment on attachment 427400 [details]
Patch

r=me

[Jiewen Tan]

Comment on attachment 427400 [details]
Patch

Thanks Brent for r+ this patch.

[EWS]

Committed r276972 (237301@main): <https://commits.webkit.org/237301@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427400 [details].